Looks like the wiring is correct for reversing polarity.
I'm assuming that the switch is:
1. Non-illuminated
2. Momentary-Off-Momentary DPDT switch
3. Rated for the required amperage and voltage
4. The power supply +/- is connected to 1/2 and the motor is connected to 1a/2a or vice-versa.
The only other thing I can think of is to ohms check the switch separate from the wiring.
1a 2a
1 2
1b 2b
Switch Centered
Connect one lead to 1, connect other lead to 1a, 1b, 2, 2a, and 2b. All should read open.
Connect one lead to 2, connect other lead to 1, 1a, 1b, 2a, and 2b. All should read open.
Switch Up
Connect one lead to 1, connect other lead to 1a. It should read continuity.
Connect one lead to 1, connect other lead to 1b, 2, 2a, and 2b. All should read open.
Connect one lead to 2, connect other lead to 2a. It should read continuity.
Connect one lead to 2, connect other lead to 1, 1a, 1b, and 2b. All should read open.
Switch Down
Connect one lead to 1, connect other lead to 1b. It should read continuity.
Connect one lead to 1, connect other lead to 1a, 2, 2a, and 2b. All should read open.
Connect one lead to 2, connect other lead to 2b. It should read continuity.
Connect one lead to 2, connect other lead to 1, 1a, 1b, and 2a. All should read open.
Scott