I think it would be fair to say if the advice is to stay away from XArcade's sticks then people should probably also stay away from the Happ's Super joystick since they are virtually the same stick. I keep hearing over and over where people recommend steering clear of XArcade but have never heard them say the same about a Happ Super. Some people (not you Turncades) haven't even used anything made by XArcade and when asked exactly what it is they didn't like about XArcade sticks and products they sheepishly admit they never used one and was just repeating what they heard.
My opinion... it's not the ultimate stick out there but it's also not the worse either.
I also hear bad things about the encoder. Again it may not be the best out there (I haven't tried any other yet to be fair and honest) but it works fine and I haven't had any of the problems others keep mentioning.
Because XGaming provide multiple adaptors to allow use with a variety of consoles they also use their own keyboard encoder instead of the de rigueur Ultimarc I-PAC. However this doesn't mean that it's in any way inadequate. I've tested with the X-Arcade default CTRL/ALT/Space MAME layout and with my own customised layout for games that don't support those key assignments (ASDZXC if you're interested). No matter how hard myself and my long-suffering wife tried we couldn't get it to either ghost, or stop accepting inputs. We could both perform the insta-kill combo setup in Guilty Gear X2 (both holding down all four attack buttons) or Zangiefs double-lariat without a hitch and even testing using XGamings test utility we ran out of fingers to hold buttons down without the Tankstick so much as blinking.
All I'm saying is XArcade seems to get a lot of heat but it really isn't as bad as I keep hearing people say. It is virtually indestructable and has a lifetime warranty, so if anything does break, they'll send a replacement part to fix it. That's a damn good deal right there! I whole heartedly agree that it doesn't look like an integrated cp and that probably turns most people off. I will also be replacing my TankStick, but not because of performance reasons, but because of looks and the fact I am going with a swappable panel system. For now though as I gather my parts and decide which way I want to construct the cp at least I am playing games and cab isn't just sitting there.
Some people like to build everything from scratch themselves, others may not have the skills or time. Considering other prebuilt cps may indeed have different/better sticks and buttons, they are also double or even triple the price... and again, I haven't had any issues with my unit at all performance wise.
I'm not trying to argue, just present a 'point counter-point' type of input. I think most people that get an XArcade unit will like it, but eventually they probably will want to make their own cp. Hell, as far as that goes if they want they could even reuse some of the parts on their new panel and just upgrade the sticks... or switch the XGaming stick to a 4-way and buy a higher end 8-way... Even the encoder can be reused if desired. Or if someone wants to connect to a PC for MAME and a game console to the same cp all they need is the adapter cable and they're set. I think for what it is it serves its purpose well.

I say if someone is in the process of building their cp, then no... XGaming's units aren't something they should even consider. If someone is new like me when I started building my cab, and still sifting through all the information as well as researching and designing their cp and knows it is going to be six months to a year before they get their 'ultimate cp' done... then sure they are worth a look. I personally would see if I could get one off eBay though at a cheaper price, that's just smart shopping.
My son is going to have a blast when he gets the TankStick when I'm done with it and he's already excited about that. So to me it wasn't a waste of money because it got me up and playing immediately, and then I can pass it on to someone and get them interested in classic arcade games. The only restriction I will give my son is when he graduates to building his own custom cp he gives it to my grandson or gives it back to me and I'll put it upstairs on my MAME test PC for a test bed. Well... that and so I can just roll my chair over and play a game!
