You will really need to be specific on what you are looking for in a joystick to have someone recommend one to you. There is really no hands down winner for everything. For example, if you play a lot of fighters, play shootem ups, or just Sinistar, your 'best' joystick will be different.
For trackballs, you can't go wrong with Happs 3" IMO, but I haven't really heard anything wrong with Imperial, Ultimarc, or GGG's TBs either.
Lightguns, there are 3 choices: Guncon2, ActLabs, and LCD TopGun. Each one has their drawbacks and I would say there isn't a clearly superior lightgun choice either.