GroovyMAME 0.171 - SwitchRes v0.015m

[ArcadeBliss]

Hi calamity. I have a racing cab and would like a grooveymame version with the racer mame diffs. (http://racermame.altervista.org/download/racermame151.zip). Could you provide a version? Thanks in advance.

Sent from my Nexus 5 using Tapatalk

[lettuce]

Never mind figured it out

[Calamity]

Hi calamity. I have a racing cab and would like a grooveymame version with the racer mame diffs. (http://racermame.altervista.org/download/racermame151.zip). Could you provide a version? Thanks in advance.

Sent from my Nexus 5 using Tapatalk

Hi ArcadeBliss,

Unfortunately the patch in there is mixed with MKChamp's so it will conflict with mine, some manual work is required to separate them and I'm sorry but don't have much time right now.

[ArcadeBliss]

Np. I will try contacting the author and if possible, I will try to build it myself

Sent from my Nexus 5 using Tapatalk

[xga]

Np. I will try contacting the author and if possible, I will try to build it myself

Sent from my Nexus 5 using Tapatalk

Hey ArcadeBliss, can you let us know how you go with your build, please.  I'd love to get Groovymame running in a driving cab with the RacerMAME diffs.

[ArcadeBliss]

Np will do

Sent from my Nexus 5 using Tapatalk

[lettuce]

Im getting a message in command prompt when i load GM...

"Invalid prescale option, reverting to '1'"

I have prescale x and y set to 6 in the HLSL section and in the OSD ACCELERATED VIDEO OPTIONS i have prescale set to 1.

Any ideas?

[ArcadeBliss]

Np. I will try contacting the author and if possible, I will try to build it myself

Sent from my Nexus 5 using Tapatalk

Hey ArcadeBliss, can you let us know how you go with your build, please.  I'd love to get Groovymame running in a driving cab with the RacerMAME diffs.

I was able to seperate out the RacerMame diffs from the hiscore diffs. I will set up a compile enviorment and have a go at it. this might take me a week or so. Just for reference, the tool "Beyond Compare 4" was great in allowing me to quickly visualize the patch contents. This allowed me to delete everything releated to the hiscore patch.

[xga]

Np. I will try contacting the author and if possible, I will try to build it myself

Sent from my Nexus 5 using Tapatalk

Hey ArcadeBliss, can you let us know how you go with your build, please.  I'd love to get Groovymame running in a driving cab with the RacerMAME diffs.

I was able to seperate out the RacerMame diffs from the hiscore diffs. I will set up a compile enviorment and have a go at it. this might take me a week or so. Just for reference, the tool "Beyond Compare 4" was great in allowing me to quickly visualize the patch contents. This allowed me to delete everything releated to the hiscore patch.

Thanks for the update, ArcadeBliss.

[haynor666]

Looks like we don't have too much code changes this time - groovymame patch 162 still compiles with most recent git repository.

[Calamity]

Looks like we don't have too much code changes this time - groovymame patch 162 still compiles with most recent git repository.

Don't say that too loud, mamedevs tend to drop their commit-bombs in the last week of the month 

[haynor666]

Yeah, I know, right now Miodrag Milanovic is creating new scripts for custom builds with specified drivers. I hope nothing will happen till 163 

[haynor666]

This we are lucky. Groovymame 163 compiles fine with 162 diff files
Fast test also passed correctly.

[Calamity]

GroovyMAME v0.163 is out (Switchres v0.015h)

- Forced prescale value to 1 when using HLSL and GLSL filters. Avoids warnings and problems.

[Doozer]

GroovyMAME v0.163 is out.

No changes in this version (just fixed the warning when about prescale when using HLSL and GLSL).

Hi Calamity,

Thank you for the quick release. I have spotted 2 changes between 0.162 and 0.163 for the same v0.015g revision.

Code: [Select]

src/osd/sdl/switchres.c
<       set_option_int_osd(machine, OSDOPTION_PRESCALE, min(3, min(best_mode->result.x_scale, best_mode->result.y_scale)));
---
>       set_option_int_osd(machine, OSDOPTION_PRESCALE, (options.gl_glsl() || game->vector)? 1 : min(3, min(best_mode->result.x_scale, best_mode->result.y_scale)));

src/osd/windows/switchres.c
<       set_option_int_osd(machine, OSDOPTION_PRESCALE, (options.d3d_hlsl_enable() || game->vector)? 0 : min(3, min(best_mode->result.x_scale, best_mode->result.y_scale)));
---
>       set_option_int_osd(machine, OSDOPTION_PRESCALE, (options.d3d_hlsl_enable() || game->vector)? 1 : min(3, min(best_mode->result.x_scale, best_mode->result.y_scale)));


[Doozer]

Version  0162 compiled fine but 0163 introduced an issue with the scope of the game variable.

Code: [Select]

../../../../../src/osd/sdl/switchres.c: In function ‘bool switchres_modeline_setup(running_machine&)’:
../../../../../src/osd/sdl/switchres.c:248:72: error: ‘game’ was not declared in this scope
  set_option_int_osd(machine, OSDOPTION_PRESCALE, (options.gl_glsl() || game->vector)? 1 : min(3, min(best_mode->result.x_scale, best_mode->result.y_scale)));
                                                                        ^


[Calamity]

Version  0162 compiled fine but 0163 introduced an issue with the scope of the game variable.

Oops! I couldn't test the linux build. Removing the " || game->vector" bit should fix it.

[Doozer]

Version  0162 compiled fine but 0163 introduced an issue with the scope of the game variable.

Oops! I couldn't test the linux build. Removing the " || game->vector" bit should fix it.

Yes, I took the same decision. Do you plan to update the diff file?

[Calamity]

Yes, I took the same decision. Do you plan to update the diff file?

Yes. I didn't increase the version number because I felt the sort of change didn't deserve it, but maybe I should?

[Doozer]

Yes, I took the same decision. Do you plan to update the diff file?

Yes. I didn't increase the version number because I felt the sort of change didn't deserve it, but maybe I should?

It would be nice in order to keep clean version history. If I can advise so.

[Calamity]

It would be nice in order to keep clean version history. If I can advise so.

Ok that needs to rebuild the files so the proper switchres version is shown (the clifront.c file includes the switchres header).

[Doozer]

It would be nice in order to keep clean version history. If I can advise so.

Ok that needs to rebuild the files so the proper switchres version is shown (the clifront.c file includes the switchres header).

I took a shortcut ;-) Sorry, too much Unix sequels

Code: [Select]

sed -i 's/0.015g/0.015h/' groovymame


[Dr.Venom]

GroovyMAME v0.163 is out (Switchres v0.015h)

- Forced prescale value to 1 when using HLSL and GLSL filters. Avoids warnings and problems.

Thanks, I almost missed this one inbetween the framedelay and ASIO heat

[Jonny G]

Hey Calamity. (Yep it's that time again!)

After getting a few errors with the new .163 diff which I fixed by removing the line break at either the line identified in the patch log, or the proceeding one, I'm getting the following output. I'm test compiling now but a little doubtful it's going to work after .162's log was clean.

Code: [Select]

Applying Diff Patch...
patching file scripts/src/emu.lua
patching file scripts/src/osd/sdl.lua
patching file scripts/src/osd/sdl_cfg.lua
patching file scripts/src/osd/windows.lua
patching file src/emu/clifront.c
patching file src/emu/drivenum.c
patching file src/emu/drivers/empty.c
patching file src/emu/emu.h
patching file src/emu/emuopts.c
Hunk #3 succeeded at 195 (offset -1 lines).
patching file src/emu/emuopts.h
patching file src/emu/machine.c
patching file src/emu/machine.h
patching file src/emu/render.c
patching file src/emu/switchres/modeline.c
patching file src/emu/switchres/monitor.c
patching file src/emu/switchres/switchres.c
patching file src/emu/switchres/switchres.h
patching file src/emu/switchres/util.c
patching file src/emu/ui/selgame.h
patching file src/emu/ui/ui.c
Hunk #1 succeeded at 1263 (offset 19 lines).
patching file src/emu/video.c
Hunk #4 succeeded at 807 (offset 60 lines).
Hunk #6 succeeded at 1092 (offset 60 lines).
patching file src/emu/video.h
Hunk #2 succeeded at 149 (offset 3 lines).
patching file src/mame/drivers/galaxian.c
patching file src/mame/includes/galaxian.h
patching file src/osd/modules/lib/osdobj_common.c
patching file src/osd/modules/lib/osdobj_common.h
patching file src/osd/modules/osdwindow.h
patching file src/osd/modules/render/drawd3d.c
patching file src/osd/modules/render/drawdd.c
patching file src/osd/modules/render/drawogl.c
patching file src/osd/modules/sound/direct_sound.c
patching file src/osd/modules/sound/sdl_sound.c
patching file src/osd/osdepend.h
patching file src/osd/sdl/input.c
patching file src/osd/sdl/osdsdl.h
Hunk #2 FAILED at 148.
Hunk #3 succeeded at 172 (offset 3 lines).
1 out of 3 hunks FAILED -- saving rejects to file src/osd/sdl/osdsdl.h.rej
patching file src/osd/sdl/sdlmain.c
patching file src/osd/sdl/switchres.c
patching file src/osd/sdl/video.c
Hunk #2 succeeded at 662 (offset 29 lines).
patching file src/osd/sdl/window.c
Hunk #11 succeeded at 1332 (offset 62 lines).
patching file src/osd/sdl/window.h
Hunk #1 succeeded at 76 with fuzz 1 (offset 2 lines).
Hunk #3 succeeded at 127 (offset 2 lines).
patching file src/osd/windows/pstrip.c
patching file src/osd/windows/pstrip.h
patching file src/osd/windows/switchres.c
patching file src/osd/windows/video.c
Hunk #1 succeeded at 222 (offset 27 lines).
patching file src/osd/windows/window.c
Hunk #9 FAILED at 904.
1 out of 9 hunks FAILED -- saving rejects to file src/osd/windows/window.c.rej
missing header for unified diff at line 5678 of patch
can't find file to patch at input line 5678
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
| mtlog_add("winwindow_video_window_update: PostMessage end");
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
8 out of 8 hunks ignored
patching file src/osd/windows/window.h
Hunk #1 succeeded at 109 (offset 3 lines).
patching file src/osd/windows/winmain.c
patching file src/osd/windows/winmain.h
Finished!
0 Hours 0 Minutes and 1 Seconds Elapsed.

Any ideas?

[Jonny G]

A guy who I built a version of GM.163 for tells me that he's also getting the 26 modeline issue when running VMmaker on that version. He's dropped back to an earlier one and its fine. Unfortunately I can't verify this as my CRT is away for repair. I appreciate you're busy with other things right now but if there's anything I can do to help diagnose this bug please let me know.

[Calamity]

After getting a few errors with the new .163 diff which I fixed by removing the line break at either the line identified in the patch log, or the proceeding one, I'm getting the following output.

Remind applying the patches with the --binary option (see the first post in this thread). This is required for the new toolchain diff/patch commands.

[Calamity]

A guy who I built a version of GM.163 for tells me that he's also getting the 26 modeline issue when running VMmaker on that version. He's dropped back to an earlier one and its fine. Unfortunately I can't verify this as my CRT is away for repair. I appreciate you're busy with other things right now but if there's anything I can do to help diagnose this bug please let me know.

You can use an older binary to extract the xml. Just use the xml from GM 0.161, and keep using GM 0.163 for actual emulation. This is not a bug, it's VMMaker that needs to be updated for the new 0.162 xml format.

[Jonny G]

OK thanks for confirming that man. What about the build errors? Am I doing the right thing in just removing the line breaks for each error that get flags. It seems to build that way but unsure if I'm going to get problems with it later on as 162 built fine with the alternate diff you posted.

[Calamity]

OK thanks for confirming that man. What about the build errors? Am I doing the right thing in just removing the line breaks for each error that get flags. It seems to build that way but unsure if I'm going to get problems with it later on as 162 built fine with the alternate diff you posted.

Build errors? Or patch errors?
You should be getting no patch errors with the --binary option.

[Jonny G]

Build errors? Or patch errors?
You should be getting no patch errors with the --binary option.

I've totally missed the binary option, I'm using MC64, where is it please?

I'm getting patch errors, I posted the output that I'm getting using MC64 v2.0.163, and MAME 0163s a few posts back if it's any help.

[Calamity]

I've totally missed the binary option, I'm using MC64, where is it please?

I'm getting patch errors, I posted the output that I'm getting using MC64 v2.0.163, and MAME 0163s a few posts back if it's any help.

Sorry, I missed the errors at the bottom. The patches in the google site were tested twice before posting them, they are fine. It certainly looks like you're not applying the patches in the right order or something. Please check again the build instructions in the first post. Notice you need to apply the hiscore patch I provide, not MKChamp's.

Regarding the --binary option, that's required since the new patch/diff tools are buggy with regards to line endings. I don't know what's the situation with MAME Compiler.

[Jonny G]

Sorry for the headache but I'm still getting errors using a command window to patch (I've previously never used anything but MC64, but pretty sure I'm doing it correctly). This is the output I'm getting from trying to apply the hiscore diff...

Code: [Select]

C:\buildtools\src\mame0163s
λ patch -p0 -E --binary <c:\buildtools\patch\hi_0163.diff
patching file scripts/src/emu.lua
patching file src/emu/emuopts.c
patching file src/emu/emuopts.h
patching file src/emu/hiscore.c
patch: **** malformed patch at line 465: diff -Nru --binary src/emu/hiscore.h src/emu/hiscore.h
This comes from a fresh extract of the mame0163 source. Thanks for all your help so far!

EDIT:

The main gm diff seems to apply fine after the hiscore diff so it's just output above that I need to sort out.

EDIT 2: Got it to build error free, possibly due to running cmd and cmder as admin. Now to hope Headkaze updates MC64 for simpletons like me.

[Calamity]

Are you using the build tools from MAMEdev?

EDIT: The diffs are tested and made with the tools from MAMEdev. Anything else may be problematic. I know the whole line ending thing shouldn't be a problem in 2015 but yes, this is how things are still.

[Jonny G]

Are you using the build tools from MAMEdev?

If you mean these ones, https://github.com/mamedev/buildtools then yes, updated via MC64 but all the same thing.

Sorry for being a pest, I know these new versions are really problematic for you. Just wanted to make sure I was up to date with the latest and greatest GM for when my monitor chassis gets back from the doctors.

[Calamity]

Just to double check I downloaded the 0.163 source again, applied the hiscore patch, zero errors:

Code: [Select]

λ patch -p0 -E --binary <hi_0163.diff
patching file `scripts/src/emu.lua'
patching file `src/emu/emuopts.c'
patching file `src/emu/emuopts.h'
patching file `src/emu/hiscore.c'
patching file `src/emu/hiscore.h'
patching file `src/emu/machine.c'
patching file `src/emu/machine.h'
patching file `src/emu/mame.c'
patching file `src/emu/profiler.c'
patching file `src/emu/profiler.h'
patching file `src/emu/ui/ui.c'

Check your patch version:

Code: [Select]

λ patch -v
patch 2.5
Copyright 1988 Larry Wall
Copyright 1997 Free Software Foundation, Inc.

This program comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of this program
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

written by Larry Wall with lots o' patches by Paul Eggert

[Jonny G]

Thanks, I will double check that too. Quick question though, how do you build a 32bit version using these tools?

[Calamity]

The error is probably an extra ascii 10 after line 254. The thing is these extra characters are added by the diff tool randomly, whatever I do. I think I'll need to make a tool to post-process the diff files and remove that crap.

In order to build 32 bit files, use the PTR64=no option.

[Jonny G]

If I use "make prt64=no" I still get a mame64.exe. Do I need to start again from scratch now that my source files have already been used to build a x64 exe?

[Calamity]

Notice the capitals.

[Jonny G]

THANKS MAN!