Both my brother and I have X-Arcade tank sticks and both of us found the stock joysticks to be pretty much unusable. Assuming you’re OK with microswitch buttons, there is nothing wrong with the buttons on X-Arcade sticks.
If I had a machine that needed parts, I wouldn’t seek out X-Arcade products to install on it just to save a few bucks. But, if you can find a good price on an X-Arcade controller, and if you replace the stock sticks with a set of Happ Competitions for about $10 each (they’re a bolt-on replacement) you’ve got yourself a very serviceable general-purpose arcade controller without having to design and build one from scratch. I bought mine because I wanted the ability to play MAME in my garage “next week” but didn’t have the time (or energy, frankly) for a full build like I have in my basement. It has done exactly what I expected it to do (after the joystick swap, that is).