Mala problem when viewing Info screen - Large PNG files don't display

[markronz]

Recently I used CPWizard to dump all the control panel pictures for each MAME game.   Then I set one of the definable layout pictures within MaLa to that directory that contained all of these new images.  Then I set it up so that these new images would be one of the screens (the first one to appear) when I pressed the Info button.    I am not sure exactly what is causing this, but it has been sporadically crashing on me lately.  This does not happen for every game.  And if it crashes, and I relaunch MaLa and I view the Info page for the exact same game as just crashed before, it will generally work.    I haven't used the Info pages too much before I generated these new images, so I can't say for sure if the new images are the problem either, or if this has always been a problem.

So, sadly, this might not be as easy of a bug to track down as the others I have recently reported.    But anyway, below are the last few lines of the mala.exe.log file.  I believe all three of them were for the same type of thing with the crash error on the Info page.

Code: [Select]

2011/01/07  22:47:50.15   Error: Exception Message: Access violation at address 004901A1 in module 'MaLa.exe'. Read of address 04430000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo
2011/01/07  23:16:30.89   Error: Exception Message: Access violation at address 004901A1 in module 'MaLa.exe'. Read of address 042A0000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo
2011/01/08  00:36:27.54   Error: Exception Message: Access violation at address 004901A1 in module 'MaLa.exe'. Read of address 02FA0000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo

Let me know if there's anything else I can do to help you track this one down.   I wasn't sure if I could provide you any other information that might be helpful.  Let me know!

[markronz]

Small update on this.   I have found that I can fairly easily get this error to reoccur.   What I do is:
In Mala, I go to a game in my MAME list.   
I press the Info button
I page around through a few different Info screens.  No specific number of screens that I can peg down.  I just page through a few.
Then I close the Info screen by pressing the Info button again.
Then I press the Info button another time to re-open the Info page yet again and it seems to crash pretty regularly.   Not every time it seems, but within 15 seconds of opening, paging through, then reopening the Info screen I can get it to crash.

Not sure if that helps you at all, but maybe that will at least give you some idea of how to duplicate the error on your end.   Let me know if you need any more info!

[loadman]

I made some significant changes to the code in that area so rather than testing that fault reported right now I might release the next beta in a couple of hours and you could tell me please if the problem continues? 

[markronz]

Good call!    I tested out the new Beta this morning.   I just did it for a few minutes, but during those few minutes I was unable to get MaLa to crash by paging through the Info pages.   It was crashing consistently last night with the old version.  With the new Beta, it seems to be working fine.    I will be still working with MaLa a fair amount over the next few weeks, so if I run into more problems with the Info pages crashing, I will let you know!

Just a thought on a possible future enhancement though that I thought I'd run by you...

On the error screen that comes up.  It just says something similar to "An error has occurred, check the mala.exe.log file for more details".   You click OK to this screen and it just goes away.   Now on certain Microsoft products, they have an extra checkbox on these types of error screens that just say something similar to "Restart this program".    By default this box is checked.  That way when you click OK, MaLa would relaunch itself.   You could also make it (if possible) so that rather than only by clicking OK, that you could also have the option of pressing the MaLa configured Select button instead.   So that way, God forbid, should there ever be a Mala crash error, the user would be able to simply press the select button, and Mala would relaunch.   This would save users from having to find a mouse to use (if one is not readily available on their machine), and also from having to click on the MaLa icon to relaunch the program again.   I'm sure my description was clear enough already, but just in case, I attached a screenshot of the idea of thing I am talking about.   I just thought that being able to recover from an error, without having to find a mouse, would make this more cab friendly.

So anyway, just thought I'd pass that on.  Not that I get THAT many MaLa errors, but I just thought this sort of thing might be helpful if I ever did.  Thanks!

[loadman]

Hey,

Not a bad idea.

I might see how difficult this is.

[markronz]

Sorry, this still appears to be occurring, so it's not quite resolved yet.  Far less often than before, but I played with MaLa for about an hour today, and during that time, MaLa crashed twice.  I have not yet been able to pinpoint any set of actions that is causing this.  All I have been doing is playing MAME games, exiting games, picking new games and viewing the Info window.  Nothing special.    If theres any more information you'd like from me to help troubleshoot this one, please let me know!

[loadman]

If you could put logging into 'Debug' level, then run mala until it happens again then send me the full log that would help a lot.

[markronz]

Can do.  I will so that in the next day or two!

[loadman]

Can do.  I will so that in the next day or two!

You could possibly tell me one thing in advance.

Are the crashes only happening when using the Info Window?

Also, When you get around to sending a full log can you also advise exactly what you were trying to do at that moment when it crashed.

[markronz]

Yes the crash happens immediately after pressing the Info button.   It's not EVERY time the info time is pressed but every time I've seen the error it happens right as I press the Info button.  Whn the error occurs, the info pages never open up.

[loadman]

Yes the crash happens immediately after pressing the Info button.   It's not EVERY time the info time is pressed but every time I've seen the error it happens right as I press the Info button.  Whn the error occurs, the info pages never open up.

At a wild guess looking the error in the first post it may be relayed to sound triggering in some scenario's MaLa trying to find teh path to the Audio file.

I wonder if this problem exists in this area.

I might add some extra logging in this area so you can use a new beta with this logging.

[markronz]

Sounds good.  However, FYI, I do not have any audio options turned on I don't think.  The only sounds in my menu are from the video files.  I will have to confirm that later though.  I did have the background music option enabled at one point but I thought. I had disabled that since then.

[markronz]

Here is my log file.  After I enabled the debug logging, I played with it long enough so that it crashed twice.    Please let me know if there's anything you'd like me to try.   Or if you need me to use some new beta version to do my testing, let me know that too.

I did look at the log a little bit myself, and it does have an error about the playlist being empty.  I am not sure if that's the ultimate cause of Mala crashing or not.  But I did confirm that I had the sounds section disabled in Mala.  So I am unsure why it's even looking up the playlist.   I have included my mala.ini file as well in case you needed that too.

Let me know what you find out, or if you need me to test again!  Thanks!

[loadman]

Nah, The Playlist is a not really a problem.

However This is very interesting ....

Thanks for testing 

I will let you know if I need you to do more tests on a newer Beta version

CRASH 1:
2011/01/09  19:37:56.04   Debug **: DisplayDefinable5:
2011/01/09  19:37:56.04   Debug **: timDisplayDelayTimer: Extra Video Delay timer started
2011/01/09  19:37:56.04   Debug **: Saving Tracking Info
2011/01/09  19:37:56.04   Debug **: FormKeyUp: Key was 78
2011/01/09  19:37:56.50   Debug **: GetLayoutPath: all files in a defined directory in layout sub dirs C:\Emulators\Mala\Layouts\MameAllGames\standardmenuH.jpg
2011/01/09  19:37:56.59   Debug **: TfrmInfo.FormShow:
2011/01/09  19:37:56.59   Debug **: TfrmInfo.PopulateWindow:
2011/01/09  19:37:56.67   Error: Exception Message: Access violation at address 004901A1 in module 'MaLa.exe'. Read of address 02FC0000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo
2011/01/09  19:37:56.67   Debug **: timInputTimer:FIRE Keyboard Poll Timer
2011/01/09  19:37:57.06   Debug **: Layout Video: Trigering delayed start

CRASH 2
2011/01/09  19:40:13.98   Debug **: DisplayDefinable5:
2011/01/09  19:40:13.98   Debug **: timDisplayDelayTimer: Extra Video Delay timer started
2011/01/09  19:40:13.98   Debug **: Saving Tracking Info
2011/01/09  19:40:13.98   Debug **: FormKeyDown: Key = 78
2011/01/09  19:40:13.98   Debug **: DisplayInfo:
2011/01/09  19:40:14.17   Debug **: FormKeyUp: Key was 78
2011/01/09  19:40:14.26   Debug **: GetLayoutPath: all files in a defined directory in layout sub dirs C:\Emulators\Mala\Layouts\MameAllGames\standardmenuH.jpg
2011/01/09  19:40:14.26   Debug **: TfrmInfo.FormShow:
2011/01/09  19:40:14.26   Debug **: TfrmInfo.PopulateWindow:
2011/01/09  19:40:14.32   Error: Exception Message: Access violation at address 004901A1 in module 'MaLa.exe'. Read of address 02FF0000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo
2011/01/09  19:40:14.56   Debug **: Layout Video: Trigering delayed start

[loadman]

Hi,

I have not fixed anything (as I could not recreate the problem) but I added extra logging that might help find this.

Please try and post log again

Download the latest beta here (link under the release version) :
http://www.malafe.net/index.php?page=download

[markronz]

Thanks, I will see if I can do the testing tonight after work with the new version.   

About the error messages you posted from the log...  specifically this line...
C:\Emulators\Mala\Layouts\MameAllGames\standardmenuH.jpg

This part is correct by the way:   C:\Emulators\Mala\Layouts\MameAllGames\

But I am not sure why it's talking about a file named standardmenuH.jpg.    I use my own background picture file that has a different name.  Likely something similar to MameAllGames.png       

Well, just wanted to point that out since I thought it was weird.   I will post my new log file as soon as I test.

[markronz]

Ok, got to do some testing earlier than I had anticipated.   Attached is my log file.  Again, I played with it until it crashed twice.  Let me know what you think!

[loadman]

About the error messages you posted from the log...  specifically this line...
C:\Emulators\Mala\Layouts\MameAllGames\standardmenuH.jpg

Opps

False Logging.

Can you please try the latest version (with even MORE logging) and post again.

Thanks for your testing.

[markronz]

OK, I got the new version and did some testing again.  It was weird, I got it to crash 2 maybe 3 times, and then I looked in the log and it was pretty short.   But I saw that there was another file, this one was named MaLa.exe20110111-1.log.txt.    So there must have been something that you changed recently, where it splits up log files.  Anyway, attached are two files.  Anything from today, 1/11 should be with the new version.   So between the two logs I got it to crash several times, I think like 3 - 5 times at least.

Let me know what you find out!

[loadman]

Ohh

When the log file reaches a certain size, it saves under a date name and starts a new file.

Thanks, I will look at logs soon. Hopefully we are pretty close now

Mmmm Issue seems to be in the LoadPicture function.

Is seems to be inconsistent as sometimes it loads a pic ok and others it does not .. On the same image

ahhh 

[loadman]

Made another version with more loggging.

We have to be close now 

As you have been doing please provide logs after it crashes at least twice

Thanks 

[markronz]

I downloaded MaLa BETA 1.739 and have been trying to test it out.  Did you change anything in this version besides adding more logging stuff?   The reason I ask is that I've been playing with it for about 10 minutes now and I haven't been able to get it to crash yet.    I have to leave now, but I will be working with this over the next few days.  So if it does crash I will be sure to post the log files here, but I just thought I'd ask you first if you changed anything else.  I wouldn't call it "resolved" yet, but somethings weird it would seem.   In the past I havent made it 10 minutes before...

[loadman]

Logging addition.

And I changed Video Player engine version

But I would appreciate you do some more testing with verbose logging still on for a while 

[markronz]

Yeah, it was just a fluke.  Got back home and first time I pressed the Info button it crashed.  Then again within like 20 seconds again.   Then it took me a few minutes, but I was able to get it to crash a third time.   Attached are all my log files.  Let me know what you find out!

[loadman]

Yeah, it was just a fluke.  Got back home and first time I pressed the Info button it crashed.  Then again within like 20 seconds again.   Then it took me a few minutes, but I was able to get it to crash a third time.   Attached are all my log files.  Let me know what you find out!

Hi, Thanks for this.

There seems to be a pattern here.....  

But randomly crashing on different files converting 'TfrmInfo.LoadPicture' to bitmap so it can process them to get the right size for the info window. By random I can see that sometimes it has no issues converting these files.

Worst case if I can't fix it I may suggest you run these *.png files through a converter to .bmp or .jpg?

But I have not given up yet,

2011/01/12  16:12:27.07   Debug **: TfrmInfo.LoadPicture: C:\Emulators\Mame\infoCard\bottom9n.png
2011/01/12  16:12:27.07   Debug **: TfrmInfo.LoadPicture: Convering to Bitmap
2011/01/12  16:12:27.09   Error: Exception Message: Access violation at address 0048FF81 in module 'MaLa.exe'. Read of address 03050000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo

2011/01/12  16:13:24.04   Debug **: TfrmInfo.LoadPicture: C:\Emulators\Mame\infoCard\mf_bdash.png
2011/01/12  16:13:24.04   Debug **: TfrmInfo.LoadPicture: Convering to Bitmap
2011/01/12  16:13:24.04   Error: Exception Message: Access violation at address 0048FF81 in module 'MaLa.exe'. Read of address 03070000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo

2011/01/12  16:27:22.00   Debug **: TfrmInfo.LoadPicture: C:\Emulators\Mame\infoCard\eprom.png
2011/01/12  16:27:22.00   Debug **: TfrmInfo.LoadPicture: Convering to Bitmap
2011/01/12  16:27:22.01   Error: Exception Message: Access violation at address 0048FF81 in module 'MaLa.exe'. Read of address 03000000, Object Function: GetLayoutPath, Exception Class: EAccessViolation, Object Class: TfrmInfo




 

[markronz]

That's a good idea.   I will wait for you to respond again before I try to find a converter.  I'll leave that as the backup plan for now.  Thanks again for the help!

[loadman]

And as you see I made a typo in the log code. Should be Converting to Bitmap

[loadman]

OK I put some error catching in.

Try that 

[markronz]

Thanks!  I'll give it a whirl in the next day or two and let you know!

[markronz]

Hey loadman, I played around with this today.    I got two error messages reported by Mala, however Mala did not crash.   My error message is attached below.  Once I clicked OK to the error message, it presented just a blank screen, which I also attached.    If I just went to the left to a different Info window, and then back to the right again, it usually worked and showed the image that just made Mala error out.   My third picture below is just what it looks like when it works.

When you said you added error handling, is that what you meant?   Just wondering.   I will admit that this is slightly better that it shows and error, but doesn't crash mala, but still not quite a fix.     I still have to find a mouse to click OK to the error message.   But at least I wouldn't have to relaunch Mala, which would be an improvement.

Just in case this was not the behavior you intended, I've attached my latest log files for you here as well.

In this is the behavior you intended, maybe I should just find that converter and convert my PNG files to JPGs then for the real fix to this?

Thanks!

[loadman]

Hi

That is great. At least you have proven it is happening while loading the graphics.

Yes I did not know it would pop up a message dialogue. I thought it would just fail to load picture sometimes.

Is it possible to email me some of the png files it fails on please 

[markronz]

Here are four I could tell it crashed on, just based on the pictures and the log tidbits you've posted to this thread:

www.markronsman.com/MalaCrashInfoCards.zip

Let me know if you need more and I could search through all my log files to figure out which pictures those might be!

[loadman]

Thanks

Give me a day or so now.

You can have a break  

[markronz]

Lol sounds good!

[loadman]

..later

Progress.

I renamed your files to be used as snaps for the first four games on my list to save me having to load the info window all the time.

I scrolled back and forth a few times and low and behold it crashed in the same type of code after 3 or 4 passes over the list

The point is now I can recreate the error, I can fix the error or at the very least stop mala crashing

       

As I say give me a day or so

It may well be having problems with those files and yes converting them may well fix it and Mala may process them faster but either way I don't want mala to crash. At the worst just don't display the graphic and put and error in the log

[loadman]

OK.

I easily got it to a point where MaLa won't crash, it just does not display the image sometimes.

I have not solved the cause yet  but only seems to happen 'sometimes' on larger PNG images.

[markronz]

Ok, cool, have you tried at all to convert the PNG files to JPG's or BMP's like you said, to see if that fixes the issue?

[loadman]

I tried JPG on a few and it seemed to be OK then .

From my HOURS of testing it only happens sometimes using larger size PNG files.

I am pretty sure it's not mala code that is failing as the failure is memory map related and it appears random

So for now we will just have to work around it.

Anyway, Im over it for now so you are welcome to test and see if you can find a pattern to when it fails.  

When you get sick of that you could try converting your graphic files to a smaller size or different format (jpg, gif or bmp) from PNG.

I'm not saying I've given up but I'm certainly over it for now  

At least MaLa does not seem to crash anymore as I am catching the exception and in that case don't display anything.

Anyway, as I say the latest beta is on the website if you feel like playing.

[markronz]

Thats cool.  I am satisfied with that resolution.  I'm happy that it won't crash Mala at least when this problem happens.  I will have to play with it some more, and if it happens to the point where it bothers me enough, which I am guessing it will, I will probably convert my photos to a different format.  Thanks again for all your work on this!