Can we add an "Artwork Crop to 4/3" option in MAME? Someone???

[Tiger-Heli]

Cross-posting this on the www.mame.net, MameWorld compiling, and BYOAC software boards.

Back around 0.61, I requested support for a "Crop to 4/3" option in MAME and Aaron Giles agreed that it would be added in a future revision.  Sample image here:  http://www.fraggersxtreme.com/museum/Temp/mame1943.jpg

However, that has not happened and now Oic has started modifying the original artfiles to achieve this.  Oic's art files are available here: http://www.disorder.org/bezel

More discussion on the advantages of adding this to mame is in this thread: http://www.mameworld.net/cgi-bin/wwwthreads/showpost.pl?Board=mamewrldstretch&Number=1833&page=0&view=expanded&mode=threaded&sb=7#Post1833

Could someone please add support for this to MAME and either submit it to the MAME devs or at least post the source code changes so we can use Oic's idea with the original artwork?  Please post a reply if you need more information.

[Tiger-Heli]

Possible code fix (but I don't know what I'm doing!!!) Could someone please review:

http://www.mameworld.net/cgi-bin/wwwthreads/showpost.pl?Board=mamewrldstretch&Number=1848&page=0&view=expanded&mode=threaded&sb=7#Post1848

[Howard_Casto]

That wouldn't crip to 3/4, that would crop to the curent aspect ratio.  (Even better)  Unfortunately I don't know if that would take the sides into account when making the aspect ratio and thus the image may get distorted.  Have you tried it yet?

[Tiger-Heli]

Have you tried it yet?

Are you kidding, it was a shot in the dark that it was even close, and I don't know how the add the artwork_43 command line.  I 'spose I could add the changes to artwork crop and have a mame that artwork crop didn't work on, but did this change.

[SirPoonga]

Have you tried it yet?

Are you kidding, it was a shot in the dark that it was even close, and I don't know how the add the artwork_43 command line.  I 'spose I could add the changes to artwork crop and have a mame that artwork crop didn't work on, but did this change.

This is in psuedo diff format.
+ means add the line where that code is, don't include the plus

Code: [Select]

/src/mame.h
   int      artwork_crop;   /* 1 to crop artwork to the game screen */
+   int    artwork_crop43;      /*  to crop 4:3 artwork to the game screen */
 

/src/windows/config.c file:
    { "artwork_crop", "artcrop", rc_bool, &options.artwork_crop, "0", 0, 0, NULL, "crop artwork to game screen only" },
+   { "artwork_crop43", NULL, rc_bool, &options.artwork_crop43, "0", 0, 0, NULL, "crop 4:3 artwork to game screen only" },
 

That should add changing options.artwork_crop43 to commandline/ini file.  rerun "mame -cc", it should appear in the ini file.
For the dos version find all occurances of artwork_crop in /src/msdos/config.c file.  Make a copy and alter it accordingly.

[Tiger-Heli]

Have you tried it yet?

Are you kidding, it was a shot in the dark that it was even close, and I don't know how the add the artwork_43 command line.  I 'spose I could add the changes to artwork crop and have a mame that artwork crop didn't work on, but did this change.

This is in psuedo diff format.
+ means add the line where that code is, don't include the plus

[code]
/src/mame.h

[SirPoonga]

Great, thanks Sir Poonga!!!

Five questions!  I have MAME source and object files at home, and it takes 4-5 hours to compile a full version.

I can just delete artwork.o and config.o from the objects directory, change the .c files in the source directory and recompile and only these files get compiled.

I've never messed with a mame.h file, did you mean mame.c?  Can I just change the mame.h file and delete mame.o in the objects directory like I do for .c files?

NO!!!
do a "make clean" then just a "make"  If it doesn;t work (IE it didn't recompile the changed files) THEN you have to start from scratch deleting the entire obj folder.  That only happens under rare occations though.  For this, a make clean should be fine.  The makefile and mingw are setup so that if a file changes it will recompile the file.  It doesn't always work, but for most things it does.  For these commandline changes, it should work fine.  I do it all the time with my skip_baddumps and buttonX hacks.

Yes, I mean the mame.h file.  You are defining a new variable in the rc_options structure.

And, once I make this change, I know how to change the .ini file.  What is the command line to turn it on?

I.e. - mame -crop43
mame - crop43
mame -artwork_crop43
mame - artwork_crop43
mame mame - artwork crop43

What ever it is, is there a negative command line?  i.e. mame -noartwork_crop43

However artwork_crop works this will work the exact same way.

BTW, what does artwork_crop do to vertical games now?  Because will both options on in the artwork file could produce abnormal effects.  They should actually be combined into one function with a if else statement
something like

if(option turned on)
    if(this game is horizontal)
        then crop with artwork_crop code
    else
        then crop with vertical code

[Tiger-Heli]

NO!!!
do a "make clean" then just a "make"  If it doesn;t work (IE it didn't recompile the changed files, THEN you have to start from scratch deleting the entire obj folder.  That only happens under rare occations though.  For this, a make clean should be fine.

Hmmmn, I always thought a make clean deleted all the obj files to start with.  I'll give it a shot anyways.

However artwork_crop works this will work the exact same way.

That's the problem, for me artwork crop works by click on the "Crop" checkbox in Emuloader.  Been a long time since I did straight command line options.  Actually, I think for testing, I will go back to my initial idea: rename mame.exe to mame-old.exe, compile the new one with just the artwork.c changes and name it mame.exe.  Play some vertical games in MAME and see what happens.

BTW, what does artwork_crop do to vertical games now?

That one I can answer, tested with centipede and space invaders, the game displays vertically full screen (if preserve aspect ratio is on), overlay art is cropped to the game screen size, bezel art is basically not shown.

 Because will both options on in the artwork file could produce abnormal effects.  They should actually be combined into one function with a if else statement
something like

if(option turned on)
    if(this game is horizontal)
        then crop with artwork_crop code
    else
        then crop with vertical code

Actually, I think you may want to add a crop with horizontal code (which would show the top and bottom portion of bezels when playing horizontal games on a vertical monitor), the new crop with horizontal code, and the existing code for horizontal vector games (or maybe the existing code would show top and bottom bezels for horizontal vector games.

I agree, the code could be combined into one function.  I will probably just test it the way I wrote it and then post the new code at www.mame.net or send it to submit@mame.net (I think that's the proper way to do it) and will include your fixes and suggestions also.

[SirPoonga]

NO!!!
do a "make clean" then just a "make"  If it doesn;t work (IE it didn't recompile the changed files, THEN you have to start from scratch deleting the entire obj folder.  That only happens under rare occations though.  For this, a make clean should be fine.

Hmmmn, I always thought a make clean deleted all the obj files to start with.  I'll give it a shot anyways.

You know what, it says it does it, but it doesn't/  It does do other nice cleanups though.

I agree, the code could be combined into one function.  I will probably just test it the way I wrote it and then post the new code at www.mame.net or send it to submit@mame.net (I think that's the proper way to do it) and will include your fixes and suggestions also.

Probably won't happen do to the fact that if both are turned on you could get some really weird effect since BOTH modify the same variables.  Like I said, it all has to be combined into one commandline option.

[Tiger-Heli]

You know what, it says it does it, but it doesn't/  It does do other nice cleanups though.

Okay, if it takes my compile 5 hours to complete, I'll know it didn't lie. :-0

Probably won't happen do to the fact that if both are turned on you could get some really weird effect since BOTH modify the same variables.  Like I said, it all has to be combined into one commandline option.

Okay, I know what you mean.  The MAME team doesn't seem to like extra work.  (meaning if I send this to them and say:  This is how it works now, This is how it should work for vertical games, This is how is should work for horizontal games . . . the way I did at MW, no one will ever take the time to code it into MAME.

Problem is, while I know what an if-then statement is, and can look at artwork.c and say "this is what crop does, and I want it to ignore this, so I need to change this", I can't write it in C, and I don't know how MAME know a vertical or horizontal game.

I 'spose what I may end up doing is testing it on vertical games and then hoping I can convince HC or Urebel to purty it up for me so it works in MAME.

Thanks again for the assist.

[SirPoonga]

Problem is, while I know what an if-then statement is, and can look at artwork.c and say "this is what crop does, and I want it to ignore this, so I need to change this", I can't write it in C, and I don't know how MAME know a vertical or horizontal game.

if(Machine->gamedrv->flags & ORIENTATION_SWAP_XY)
{
  Vertical
}
else
{
  horizontal
}



BTW, that happens when atrwork_crop is 1
[code]

[SirPoonga]

Ok, here's the code.  Maybe I will submit it:)

You can submit it, just say I helped out and here's how I tested it

"mame 1943"
"mame -ror 1943"
"mame pacman"
"mame -ror pacman"
"mame ddragon2"
"mame -ror ddragon2"

I ran those 6 lines with the 4 possible combinations of

artwork_crop            0 or 1
artwork_filledges       0 or 1

artwork_filledges won't work unless artwork_crop = 1

Also mention this was done with .66 windows version.  As the config.c for each OS will need to be changed accordingly.  It should work with any version of mame that implemented artwork_crop.  It's usage is the same as artwork crop with the addition it won't do anything if artwork_crop is disabled.


btw, if you don't want to compile it and test it get into chat using mirc and I will dcc you the exe.

To use the text file, it is in diff format.  Use patch to patch the source.  It isn;t many lines, you could easily do it by hand.  You will see a line that says diff file 1 file 2, that tells you which file to change.
then there are line numbers
then anything with a + is an addition, anything with a - is a subtraction.  There are only additions with this.  Put the additions (without the plus sign at the beginning of the line)  in the location specified.  diff format included lines around the area so you know for sure where to add.


I'm going to reply to the cross postings too.

[Tiger-Heli]

if(Machine->gamedrv->flags & ORIENTATION_SWAP_XY)
{
  Vertical
}
else
{
  horizontal
}

That doesn't tell me enough to write the code either.  Although maybe it does tell me enough to write something and see where it fails and what changes make it work right which is really the best way to learn software anyway!

BTW, that happens when atrwork_crop is 1
Edit:  errrr, if artwork_crop = 1 then that code DOESN'T get executes, it's (!options.artwork_crop) instead of (options.artwork_crop)

Ah, so the exclamation point means DON'T execute the code if true!  All I know is artwork crop does more than I want (scales artwork in X and Y, rather than just Y).  I can predict one of five things will happen though:

1. My code will work for vertical games as is (unlikely) . . .

Never mind saw your next post. . .  

I'll look at the code a little closer later.  I'm a math major, it's just some simple math to calculate all this crap...

I'm an engineer, and it looks like I got it to work but don't know what it's doing, which speaks volumes!!!

[SirPoonga]

if(Machine->gamedrv->flags & ORIENTATION_SWAP_XY)
{
  Vertical
}
else
{
  horizontal
}

That doesn't tell me enough to write the code either.  Although maybe it does tell me enough to write something and see where it fails and what changes make it work right which is really the best way to learn software anyway!

actually it does, you throw that in artwork.c, fill in the { } with usable code:)
I just wanted to show it is possible.

BTW, that happens when atrwork_crop is 1
Edit:  errrr, if artwork_crop = 1 then that code DOESN'T get executes, it's (!options.artwork_crop) instead of (options.artwork_crop)

Ah, so the exclamation point means DON'T execute the code if true!  All I know is artwork crop does more than I want (scales artwork in X and Y, rather than just Y).  I can predict one of five things will happen though:

actually the ! means NOT.

[Tiger-Heli]

>Ok, here's the code.  Maybe I will submit it:)
>You can submit it, just say I helped out and here's how I >tested it

I take it I'm (TH) supposed to submit it.  I'll give you most of the credit.  You did the hard work I just came up with the blatantly obvious.

>btw, if you don't want to compile it and test it get into chat >using mirc and I will dcc you the exe.

Please check your PM and mail it to me.  THANKS!!!!

>I'm going to reply to the cross postings too.

Cool, thanks!!!!

[SirPoonga]

>Ok, here's the code.  Maybe I will submit it:)
>You can submit it, just say I helped out and here's how I >tested it

I take it I'm (TH) supposed to submit it.  I'll give you most of the credit.  You did the hard work I just came up with the blatantly obvious.

>btw, if you don't want to compile it and test it get into chat >using mirc and I will dcc you the exe.

Please check your PM and mail it to me.  THANKS!!!!

>I'm going to reply to the cross postings too.

Cool, thanks!!!!

I submitted it, said you helped out, we'll see who they give the credit

[Howard_Casto]

So did it work as expected?

[SirPoonga]

So did it work as expected?

"it" as in the the code posted on mameworld.net?  I didn't even look at it closely.  The diff file I attached is all from me.

[SirPoonga]

to use the diff file

copy the dif file to to the mame source folder (not the src folder, the main folder with the makefile)
patch -u -p 1 -i cropedges.txt

patch needs to go in your path, say the mingw bin folder
http://gnuwin32.sourceforge.net/packages/patch.htm

[SirPoonga]

Doh, there is a problem with the hack, stay tuned....

[SirPoonga]

http://www.urebelscum.speedhost.com/dl/pat253b.zip
use that patch.

[SirPoonga]

Here we go, this hack is MUCH better.  Had to use some math.  Give it a try.  try all sorts of weird configurations.

[Tiger-Heli]

This has me baffled:

I tried Poonga

[Howard_Casto]

The initial patch didn't work with rotation correctly.  That's why he made the second.  I've been testing for him and it works great now.  Let me know if you need help.  

[Tiger-Heli]

This is awesome!   I just fired up about 20 vertical games in MAME!  It works great and adds a lot of realism to the game.  The performance hit isn