Main > Software Forum
hiscore diff (with no nag/white box removal)
t3ckn0b0y:
bingo ... thanx for all the help guys.. :dizzy:
this rounds for you :cheers: :applaud: :notworthy:
t3ckn0b0y:
Thanks for this great patch MKChamp.. I'm always looking forward to
updates.. :notworthy:
Pitou:
Hello,
First, thanks MkChamp for the patch, but there is one problem for me applying these modifications.
Since I'm using a fixed 60hz display, I'm using the refreshspeed option for mame to slow down a little bit some games, correcting audio glitches.
I don't want to change the speed option to say 0.98, since it will slow down all games even those that run under 60hz.
It seems that the calculation is done during startup screens (they're now gone!), so the calculation is wrong. For example on a 60hz display, using refreshspeed 1 in mame.ini, dkong should run steady at 98.00%. Now it's random and audio glitches appear.
Here is what I did to patch the problem. But if you find a better way, I'll welcome it with open arms!
Or is there a way you could include this little patch?
-------------------------------------------------------
For mame 0.123:
In mame.ini, set: refreshspeed 60 (instead of 0 or 1, Boolean changed for an Integer)
In ./src/emu/video.c:
Line #291:
global.refresh_speed = options_get_bool(mame_options(), OPTION_REFRESHSPEED);
Change for:
global.refresh_speed = options_get_int(mame_options(), OPTION_REFRESHSPEED);
-------------------------------------------------------
Line #752:
if (global.refresh_speed)
Changed for:
if (global.refresh_speed != 0)
I might not need to modify this one since "60 == True" in C language
-------------------------------------------------------
Line #754:
float minrefresh = render_get_max_update_rate();
Changed for:
float minrefresh = global.refresh_speed;
Basically, what I do, is just set the refresh speed to 60hz statically. I can actually change it to whatever I want, something like 59 if I want to be safe with my display.
I guess the dynamic calculation is more precise depending on the display used.
Any comments?
Thank you.
Pitou!
MKChamp:
Nice find Pitou!
I've uploaded a new diff (starting with 123u3 that corrects this refreshspeed bug. I'm not sure adding your 'patch' to the hiscore diff would be the right thing to do, however, because it might not be suitable for the majority of people using it. 2 options available for you to try is:
1) In your mame ini file, set the following lines:
speed 2.0
refreshspeed 1
This is the setting most people seem to have the best success with for the games that run at 60.
2) Create your own little diff for applying your patch. You may already know how, but just in case you are not sure:
a) Patch the mame source with all the u diffs and then the hiscore diff. Copy the src folder and rename the copied folder to "old"
b) Patch the original src folder with your changes. So the directory will have the src folder with all the diffs applied plus your patch...and the old folder with all the diffs applied minus your patch.
c) then run "diff -r -c -N old/ src/ > your_patch_name.diff"
This will create your own diff that you can apply in the future to any version of mame (unless the src changes drastically enough to not be able to apply your patch. Of course, you will need the diff.exe which can easily be obtained on the web.
Let me know how it goes!
Pitou:
Hey thanks for the fix!!
For sure I could create my own diff, but, I'm gonna test your fix and if it works fine, I'm not going to use my patch anymore :)
2 quick questions:
1- Along with refreshspeed 1, why using a speed of 2.0?
2- I didn't take time to look at differents hi_diff files yet, so, to simplify my life :) can you tell me what you did? Before discovering this thread, I was patching all screens by myself, white box etc... but never found a way to fix the refreshspeed.
Thank you very much!
Pitou!
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version