Main > Software Forum
hiscore diff (with no nag/white box removal)
ozfalcon:
--- Quote from: h0tw1r3 on April 16, 2016, 10:47:14 pm ---I came up with my own patch for uxme because these patches never actually removed the white border. It appeared to work because when all messages are hidden the white border is never rendered. If any message is displayed before the machine starts, a white border will still be rendered.
Here's my take in patch form: https://playground.zaplabs.com/sandbox/kb/arcade/emulation/mame/mods/version/0.172/skip-messages-and-remove-white-border.patch.source
Provides three separate options: skip_loading, skip_warning, and render_border.
--- End quote ---
It's obvious now to see why the Disable Nag in the Hi_Score patch was affecting the Loading messages (Kind of a double up on function).
ozfalcon:
Updated Hi_Score Patch 0.172c.txt
Hi_Score 0.172 has been repaired for both Win & SDL to provide expected operational behaviour.
It only deals with the suppression patches and does not alter the Hi_Score patch in any way.
In a nutshell, I noticed the suppression patches were not working correctly for SDL Mame (& Probably Windows too).
This patch has been built under the MinGW (Windows) environment and can be used by either Windows or SDL users.
Patch Notes:
The patch has been built on a Win7 64bit system in the MinGW environment (http://mamedev.org/tools/)
The patch has been compiled/tested on a Win7 64bit system.
The patch has been compiled/tested on a Linux 32bit system.
Mac has not been tested.
ozfalcon:
Updated Hi_Score Patch 0.172d.txt
For end users, skip_gameinfo needs to be set in mame.ini
For maintainers, The suppression patches have been simplified.
Key points of Rev D
* KISS Philosopy applied to suppression patches - Making them simple & easy to maintain.
* Suppression & Hi_Score code separated in both diff & source files.
* Detailed explanation of suppression patches.
* Hi_Score code unaltered.
There are two areas to deal with regarding suppression of messages.
Note: The depth of patch is important, We want to keep it moderate as to not make the patch too abstract.
1. The Initializing, Loading & Decrypting messages.
2. The Warning (User input to continue) messages.
1. The Initializing, Loading & Decrypting messages.
These messages are sent via different subroutines to the "set_startup_text" function.
fgrep "ui().set_startup_text" * -R
--- Code: --- emu/machine.cpp: ui().set_startup_text("Initializing...", true);
emu/romload.cpp: machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp: machine.ui().set_startup_text(loadingMessage,FALSE);
--- End code ---
The current patch disables the message at each subroutine.
The natural progression is to follow the path and disable at the "set_startup_text" function.
This also has the benifit of being simpler and not interfering with the Hi_Score patch files.
The new method disables all the messages by immediately returning from the "set_startup_text" function call.
2. The Warning (User input to continue) messages.
These messages are all sent via the "display_startup_screens" function.
The old patch disables all interactive messages regardless of message type.
--- Code: --- 1. show_warnings
2. show_gameinfo
3. show_mandatory_fileman (Mess related notice, May be ignored/omitted)
--- End code ---
The new method targets show_warnings only, And will still display game_info if enabled.
(skip_gameinfo may be enabled/disabled by the standard Mame configuration option)
Build Notes:
This patch has been built under the MinGW (Windows) environment and can be used by either Windows or SDL users.
Patch Notes:
The patch has been built on a Win7 64bit system in the MinGW environment (http://mamedev.org/tools/)
The patch has been compiled/tested on a Win7 64bit system.
The patch has been compiled/tested on a Linux 32bit system.
Mac has not been tested.
ozfalcon:
The next logical step might be to tie all the suppression patches to "skip_gameinfo" thereby making the suppression patches fully separated from the Hi_Score patch (ie. declarations) AND able to be toggled on/off by the standard Mame "skip_gameinfo" option.....
ozfalcon:
Updated Hi_Score Patch 0.172e.txt FINAL
This should be the final release of the updates.
Summary of changes
* hi_172c - Repair of suppression patches.
* hi_172d - Simplify suppression patches.
* hi_172e - Liberate suppression patches.
Key points of Rev E
* KISS Philosopy applied to suppression patches - Making them simple & easy to maintain.
* Suppression patches now toggled on/off by the Mame "skip_gameinfo" option.
* Suppression & Hi_Score code separated in both diff & source files.
* Hi_Score code unaltered.
Maintenance note: The suppression patches have been fully separated from the hi_score patch (ie declarations).
Build Notes:
This patch has been built under the MinGW (Windows) environment and can be used by either Windows or SDL users.
Patch Notes:
The patch has been built on a Win7 64bit system in the MinGW environment (http://mamedev.org/tools/)
The patch has been compiled/tested on a Win7 64bit system.
The patch has been compiled/tested on a Linux 32bit system.
Mac has not been tested.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version