Main > Software Forum

hiscore diff (with no nag/white box removal)

<< < (216/250) > >>

ozfalcon:
Interesting, Looking at the loading patch - And it is forced on regardless of the config option setting.

+  //if (!options_get_bool(mame_options(), OPTION_DISABLE_LOADING_PATCH))
+    return;



--- Quote ---I came up with my own patch for uxme because these patches never actually removed the white border. It appeared to work because when all messages are hidden the white border is never rendered. If any message is displayed before the machine starts, a white border will still be rendered.

Here's my take in patch form: https://playground.zaplabs.com/sandbox/kb/arcade/emulation/mame/mods/version/0.172/skip-messages-and-remove-white-border.patch.source

Provides three separate options: skip_loading, skip_warning, and render_border.

--- End quote ---

You have probably done what I was just about to do. Thanks for the link I'll have a look and read.
Given that the Hi_Score patch will more than likely move to the LUA script, It's probably time to look at liberating the other patches.

Of Course I really have no say in what happens - That's upto MKChamp - But I'm sure he's keen as previously indicated.

ozfalcon:

--- Quote from: h0tw1r3 on April 16, 2016, 10:47:14 pm ---I came up with my own patch for uxme because these patches never actually removed the white border. It appeared to work because when all messages are hidden the white border is never rendered. If any message is displayed before the machine starts, a white border will still be rendered.

Here's my take in patch form: https://playground.zaplabs.com/sandbox/kb/arcade/emulation/mame/mods/version/0.172/skip-messages-and-remove-white-border.patch.source

Provides three separate options: skip_loading, skip_warning, and render_border.

--- End quote ---

Just looking at your Skip_Loading sections compared to Hi_Score Disable_Loading_Patch

It seems there are three areas of interest:
fgrep "ui().set_startup_text"  * -R

--- Code: ---emu/machine.cpp: ui().set_startup_text("Initializing...", true);
emu/romload.cpp: machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp: machine.ui().set_startup_text(loadingMessage,FALSE);

--- End code ---

Your patch does:
emu/machine.cpp:   ui().set_startup_text("Initializing...", true);
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);

Hi_Score does:
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp:         machine.ui().set_startup_text(loadingMessage,FALSE);

Any reason your patch does not alter cps2crpt.cpp?

Will look at the rest of the patch (skip_warning, and render_border) over the week.

h0tw1r3:

--- Quote from: ozfalcon on April 17, 2016, 09:51:39 am ---
Just looking at your Skip_Loading sections compared to Hi_Score Disable_Loading_Patch

It seems there are three areas of interest:
fgrep "ui().set_startup_text"  * -R

--- Code: ---emu/machine.cpp: ui().set_startup_text("Initializing...", true);
emu/romload.cpp: machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp: machine.ui().set_startup_text(loadingMessage,FALSE);

--- End code ---

Your patch does:
emu/machine.cpp:   ui().set_startup_text("Initializing...", true);
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);

Hi_Score does:
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp:         machine.ui().set_startup_text(loadingMessage,FALSE);

Any reason your patch does not alter cps2crpt.cpp?

Will look at the rest of the patch (skip_warning, and render_border) over the week.

--- End quote ---

Thanks for reviewing the patch. Uploaded a new version. Removed some irrelevant code, fixed the cps2 decrypt message showing and simplified.

ozfalcon:
For a different method of message suppression and writeup on using the MinGW environment.
http://forum.attractmode.org/index.php?topic=348.0

ozfalcon:
Just looked at the latest revision of @h0tw1r3 patch :burgerking:

This patch pretty much gets to the root of each area.
Looks like a much cleaner way of doing things.
& it's small - So it should be easy to manage..

Still have to test it out.

Navigation

[0] Message Index

[#] Next page

[*] Previous page