The NEW Build Your Own Arcade Controls

Software Support => DOS/WinCab => Topic started by: Chris on July 27, 2006, 01:43:21 am

Title: Testing: Indexing fix for filenames with international characters
Post by: Chris on July 27, 2006, 01:43:21 am
For those people who have files with international characters that WinCab has not been able to find/index/erxtract tags from/play:  Can you try the executable at http://webpages.charter.net/celamantia/jukebox/wincabb9.zip and see if it solves any or all of these problems?

NOTE: This executable has not been tested much and should not be considered stable, so I recommend you back up your original wincab.exe first.

Thanks!

--Chris

Title: Re: Testing: Indexing fix for filenames with international characters
Post by: JustMichael on July 27, 2006, 04:45:28 am
For me, each time WinJukebox encounters one of the files it says:

ERROR
Cannot get file size
The location of the file and its name

I click 'OK' then WinJukebox says the following about that same file:

ERROR
Cannot load MP3 file
The location of the file and its name

I then click 'OK' and WinJukebox will continue processing files until it hits the next filename with international characters then it says those same things again about the new file.
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Lave Laar on July 27, 2006, 05:22:39 am
I get the same errors as JustMichael.
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on July 27, 2006, 08:14:57 am
For me, each time WinJukebox encounters one of the files it says:

ERROR
Cannot get file size
The location of the file and its name

I click 'OK' then WinJukebox says the following about that same file:

ERROR
Cannot load MP3 file
The location of the file and its name
Does the filename look correct in the error messages?

What are a couple of the filenames that are being choked on?

Thanks for your help!

--Chris
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Lave Laar on July 27, 2006, 01:35:20 pm
The filenames look correct in the errormessages.

Examples on filenames that doesn't work :
- "Folk og R
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: pascal on July 27, 2006, 04:41:13 pm
Hello,

Same error with French characters...

Regards
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: JustMichael on July 27, 2006, 06:50:21 pm
The name and location of the files it errors on look perfect.
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on July 27, 2006, 10:52:34 pm
The name and location of the files it errors on look perfect.

Thank you!  Working on it now....
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on July 28, 2006, 12:18:42 am
OK, I'm getting some really weird results with this... going to have to pull this apart and rebuild it, I think...
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on July 30, 2006, 01:06:10 am
Tinkered some more; let's try this again.  Can you try the executable at http://webpages.charter.net/celamantia/jukebox/wincabb9.zip and see if it solves any or all of these problems?

Once again, this executable has not been tested much and should not be considered stable, so I recommend you back up your original wincab.exe first.
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Ralfx on July 30, 2006, 06:53:48 am
Tinkered some more; let's try this again.  Can you try the executable at http://webpages.charter.net/celamantia/jukebox/wincabb9.zip and see if it solves any or all of these problems?

Once again, this executable has not been tested much and should not be considered stable, so I recommend you back up your original wincab.exe first.



Hi Chris

You've done a great job again !

Tested it on a german win xp and it works fine. No "Various Artists" or "Directory Artists" any more.  :applaud:

Thank you very much  :cheers:
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on July 31, 2006, 02:20:49 am
Great!  Thank you for checking this out!

Note that in this version, I believe CD skins are completely broken, so again it's not ready for human consumption... it's really just for testing that Unicode fix.  I'm working on it.

--Chris
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: JustMichael on August 02, 2006, 06:18:23 am
Well it does read the files now.  Blue
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on August 02, 2006, 02:27:34 pm
Hmm... I must not be using a Unicode-compatible comparison in the sort.  Should be an easy fix.  Thank you for finding this!
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on August 02, 2006, 09:48:28 pm
Oddly enough, the Unicode comparison routines I'm using use the ASCII collating sequence... odd. I'll figure it out.
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Lave Laar on August 03, 2006, 04:16:20 pm
I believe that this is actually the way it's supposed to be.  The
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: JustMichael on August 03, 2006, 07:55:40 pm
not if the "
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on August 03, 2006, 08:40:41 pm
Chris, I do have an idea though.  Why not add an option for sorting those letters as "normal" letters or as your routine currently sorts them?  Then people could have it either way they like...

Excellent idea...  I can't possibly know the "correct" alphabetical order for every language that uses high-order characters...  Especially since, theoretically, song titles could be in Chinese characters. Korean, Arabic, presuming the font supports it (the included default font does have the Arabic characters at least)...

--Chris
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: JustMichael on August 08, 2006, 09:42:11 pm
Well I hope to see something soon.   ;D
Title: Re: Testing: Indexing fix for filenames with international characters
Post by: Chris on August 08, 2006, 10:10:06 pm
Me too.  :)

I think I just found the place where CD skins are broken... and now my question isn't "Why isn't it broken" so much as "How did it ever work in the first place?"  I've found a huge design flaw that didn't show itself before because two constants happened to coincidentally have the same value; now that they don't, it's all broken.  Yet another section to gut and redesign from sctatch...