Build Your Own Arcade Controls Forum

Main => Software Forum => Topic started by: EMDB on September 15, 2015, 05:45:07 am

Title: Donkey Kong Pauline Edition Patch for MAME
Post by: EMDB on September 15, 2015, 05:45:07 am
Since the new architecture of MAME (with the Arcade sub target) I'm not able to build a custom version incorporating support for the patched Donkey Kong Pauline Edition.

I patched dkong.c like before adding entries for the specific version:

Code: [Select]
GAME( 2013, dkongpe,   dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  "hack", "Donkey Kong - Pauline Edition", MACHINE_SUPPORTS_SAVE ) /* from Clay Cowgill's Romhack */

ROM_START( dkongpe ) /* Hack from Clay Cowgill - Pauline Edition */
ROM_REGION( 0x10000, "maincpu", 0 )
ROM_LOAD( "c_5et_g.bin",  0x0000, 0x1000, CRC(ba70b88b) SHA1(d76ebecfea1af098d843ee7e578e480cd658ac1a) )
ROM_LOAD( "c_5ct_g.bin",  0x1000, 0x1000, CRC(45af403e) SHA1(6030a4af7df98bfdf5b35a9a42541566f7d12901) )
ROM_LOAD( "c_5bt_g.bin",  0x2000, 0x1000, CRC(3a9783b7) SHA1(e98d757c048f2180ba22c774e0e425ddc661ba8c) )
ROM_LOAD( "c_5at_g.bin",  0x3000, 0x1000, CRC(32bc20ff) SHA1(ef141f437912923625722b83a33ea182eaa31427) )
/* space for diagnostic ROM */

ROM_REGION( 0x1800, "soundcpu", 0 ) /* sound */
ROM_LOAD( "s_3i_b.bin",   0x0000, 0x0800, CRC(45a4ed06) SHA1(144d24464c1f9f01894eb12f846952290e6e32ef) )
ROM_RELOAD(               0x0800, 0x0800 )
ROM_LOAD( "s_3j_b.bin",   0x1000, 0x0800, CRC(4743fe92) SHA1(6c82b57637c0212a580591397e6a5a1718f19fd2) )

ROM_REGION( 0x1000, "gfx1", 0 )
ROM_LOAD( "v_5h_b.bin",   0x0000, 0x0800, CRC(007aa348) SHA1(ff2ae583fef6da9d260fda8f4a896dd0414c3388) )
ROM_LOAD( "v_3pt.bin",    0x0800, 0x0800, CRC(a967aff0) SHA1(7bcfdbeb0a5cdfec604eb8450664bc4b789526be) )

ROM_REGION( 0x2000, "gfx2", 0 )
ROM_LOAD( "l_4m_b.bin",   0x0000, 0x0800, CRC(766ae006) SHA1(0ec53798aa2c30b2c5c8b2f99b811a187faa2549) )
ROM_LOAD( "l_4n_b.bin",   0x0800, 0x0800, CRC(39e7ca4b) SHA1(b77ddd39608d08013fa8bb764c8e5aa4e03181dc) )
ROM_LOAD( "l_4r_b.bin",   0x1000, 0x0800, CRC(012f2f25) SHA1(836709192a249b00ded783be542ee844eb930c7a) )
ROM_LOAD( "l_4s_b.bin",   0x1800, 0x0800, CRC(84eb5bfb) SHA1(c1f38efb8670f1a489275eb8ff576a95d140cfb9) )

ROM_REGION( 0x0300, "proms", 0 )
ROM_LOAD( "c-2k.bpr",     0x0000, 0x0100, CRC(e273ede5) SHA1(b50ec9e1837c00c20fb2a4369ec7dd0358321127) ) /* palette low 4 bits (inverted) */
ROM_LOAD( "c-2j.bpr",     0x0100, 0x0100, CRC(d6412358) SHA1(f9c872da2fe8e800574ae3bf483fb3ccacc92eb3) ) /* palette high 4 bits (inverted) */
ROM_LOAD( "v-5e.bpr",     0x0200, 0x0100, CRC(b869b8f5) SHA1(c2bdccbf2654b64ea55cd589fd21323a9178a660) ) /* character color codes on a per-column basis */
ROM_END

It compiles just fine but when I try to launch dkongpe I get an "Unknown system 'dkongpe'" error message. I probably should add dkongpe to some new list of supported games for the Arcade sub target?

Can anybody help me on this? I will add the new patch here once I get it working again.
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition
Post by: Haze on September 15, 2015, 12:25:38 pm
you need to add dkongpe to src\mame\arcade.lst

note, this might change in future versions, the 'arcade only' build is being phased out in favour of having the option of a complete build or single driver build which makes more sense from a development perspective.  (it's possible future compile scripts will pick up all sets in a driver without having to add it to the .lst files - the single driver config already does that)

Title: Re: MAME 0.165 and Donkey Kong Pauline Edition
Post by: EMDB on September 15, 2015, 12:43:34 pm
you need to add dkongpe to src\mame\arcade.lst

note, this might change in future versions, the 'arcade only' build is being phased out in favour of having the option of a complete build or single driver build which makes more sense from a development perspective.  (it's possible future compile scripts will pick up all sets in a driver without having to add it to the .lst files - the single driver config already does that)
Thanks! I was hoping you would respond  :applaud:
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition
Post by: EMDB on September 15, 2015, 05:17:59 pm
Fixed  :cheers: :cheers: :cheers:

(https://dl.dropboxusercontent.com/u/82432150/Retrocade/mame165-dkongpe.png)
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EMDB on September 17, 2015, 11:38:29 am
Added the patch as promised...
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: lamprey on September 17, 2015, 12:52:41 pm
Added the patch as promised...
Sweet! Thanks for this!
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EvilNuff on September 21, 2015, 07:27:03 pm
I hope you don't mind a newb question, is this a recompile of mame or the rom or both?
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: Thenasty on September 21, 2015, 08:40:29 pm
I hope you don't mind a newb question, is this a recompile of mame or the rom or both?

no to both.

This patches the source (adding/removing/appending some lines etc...) so you can compile you own version with this game added.
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EvilNuff on September 21, 2015, 11:08:57 pm
I hope you don't mind a newb question, is this a recompile of mame or the rom or both?

no to both.

This patches the source (adding/removing/appending some lines etc...) so you can compile you own version with this game added.

So what are you recompiling if not mame?

I tried applying the patch to mame 0.165 and got a failure to apply patch:
patching file `src/mame/drivers/dkong.c'
Hunk #1 FAILED at 2156.
Hunk #2 FAILED at 3295.
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EMDB on September 22, 2015, 02:44:34 am
I hope you don't mind a newb question, is this a recompile of mame or the rom or both?

no to both.

This patches the source (adding/removing/appending some lines etc...) so you can compile you own version with this game added.

So what are you recompiling if not mame?

I tried applying the patch to mame 0.165 and got a failure to apply patch:
patching file `src/mame/drivers/dkong.c'
Hunk #1 FAILED at 2156.
Hunk #2 FAILED at 3295.
You're recompiling Mame to add support for a patched version of the donkey kong rom set (called dkongpe) which swaps Mario and Pauline. I will check the patch file when I'm home later tonight...
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EvilNuff on September 22, 2015, 08:55:54 am
Thanks that is what I had assumed.  I have created the patched dkongpe.zip and am trying to apply the patch and recompile but running into errors.  I'm going to reset my 0.165 back to source and try from scratch.

Edit: oops to be clear I was able to apply the patch using the command line patchmame bat file.  However, in trying to recompile afterwards my compilation is now erroring when doing the final linking.  Using mame compiler 64 for the compile and not the command line if that matters.

If it matters, during applying this patch file I get the prompt:
Reversed (or previously applied) patch detected!  Assume -R?
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EMDB on September 22, 2015, 01:19:35 pm
I messed up the patch by switching old and new files   :angry:  I created a new one and tested it on a clean source. It works fine now. I'm sorry for the inconvenience...

(https://dl.dropboxusercontent.com/u/82432150/Retrocade/dkongpe-patch.jpg)
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EvilNuff on September 22, 2015, 06:37:13 pm
That worked for me, thanks much!
Title: Re: MAME 0.165 and Donkey Kong Pauline Edition - *** ADDED PATCH ***
Post by: EMDB on November 19, 2015, 05:38:01 pm
When trying to patch the sources from the latest MAME 0.167 for Donkey Kong Pauline Edition I noticed to my surprise that it already contained support for this hack  :applaud: There's nothing in the release notes though  ???
Title: Re: Donkey Kong Pauline Edition Patch for MAME
Post by: ballboff on June 21, 2016, 08:37:29 am
Sorry for re-opening up an old thread.  It did warn me and ask me if I wanted to start a new thread, but I figured that would have been even more rude by creating a new thread when one already existed.  My question is that I want to know is it possible to get donkey kong pauline working on older mame versions, such as 0.78?  or is there another way it can be adapted to run on a raspberry pi?