hiscore diff (with no nag/white box removal)

[GAJoe]

If you are positive you started with a totally clean source, then the only way this could have happened is if you accidentally applied 2 different version hiscore diffs by mistake. That would be the only way I could imagine that *could* happen...or your machine has gremlins ;-)

I vote gremlins.  Though human error on my part is the more likely culprit.  I downloaded the source and the diff again, and after patching checked the video.c file.  It only had the osd_update_hi section once, so I'm guessing I either patched twice and somehow didn't notice or I did what you mentioned and used two different patches.  In any case, it's all resolved now.  Let that be a lesson to everyone else, don't patch your source code twice.

[MKChamp]

Just FYI, I re-uploaded hi_125u2 (on 5-23 at 1:40pm). The way to determine if playback/recording is activated changed significantly in 125u2 and I finally got around to implementing it in the hiscore diff. The original hi_125u2 just discarded this check and would enable hiscores regardless if playback/recording was running.

[MKChamp]

More files....

edit - all files are contained in the original post

[tommyinajar]

I'm getting an error when trying to add the Hi.110.diff to 110 Mame - I even went and deleted the files & retried the steps in case I made a mistake, which is highly unlikely  since this is my first shot at compiling....

It goes well for 10 seconds or so then-

cc1exe: error: unrecognized command line option “-Who-unused- functions” ming32-make *** [obj/mame/audit.o] Error 1

  Any Source Code experts out there ??

[MKChamp]

I'm getting an error when trying to add the Hi.110.diff to 110 Mame - I even went and deleted the files & retried the steps in case I made a mistake, which is highly unlikely  since this is my first shot at compiling....

It goes well for 10 seconds or so then-

cc1exe: error: unrecognized command line option “-Who-unused- functions” ming32-make *** [obj/mame/audit.o] Error 1

  Any Source Code experts out there ??

This will happen if you use the tools designed to build MAME versions 119 or newer. Perhaps Headkaze can chime in...maybe his compiling tool can handle older builds.

[tommyinajar]

Thats funny you mentioned that, I just tried his http://forum.arcadecontrols.com/index.php?topic=79389.0 and the same result on two different computers, I even uninstalled / installed Framework 2.0. , thinking that might have got messed up somehow.

The funny thing is in the last post in that thread, someone did patch .0110  mame *somewhat* succesfully.

[massive88]

Theres a little box in Headkaze's proggie to click if you are compiling sources older than 0.118, did you make sure that was ticked?

[tommyinajar]

Theres a little box in Headkaze's proggie to click if you are compiling sources older than 0.118, did you make sure that was ticked?

Now I do-

It-is-a-compiling, with only a few errors, but none fatal - I'll give it a whirl, Thanks.

[t3ckn0b0y]

when using the hiscore125u3.diff file im getting an error in clrmamepro,
trying to isolate it .. dont know if others have had the same problem or
not... 

found an incomplete datfile or bad exe output
last correctly imported set scramblb...   ? 

any ideas?

[t3ckn0b0y]

Okay, I tried without the hiscore.diff  still got the problem, it isnt
the patch... still puzzled.. going to redownload the source for .125
and attempt to recompile again...

[nuka1195]

http://mametesters.org/mantis/view_all_bug_page.php

[MKChamp]

http://mametesters.org/mantis/view_all_bug_page.php

I think a guy name Judge posted a fix:
to quote:
Not too sure if this is the fix, in src/emu/inptport.c around line 630 in the error_buf_append function:

Code:
int curlen = (errorbuf != NULL) ? strlen(errorbuf) : 0;

[t3ckn0b0y]

thank you very much worked like a charm. fixed the whole problem.   
I was beginning to  there for a moment.. LOL  everyone on here is always
helpful.. thats one thing I love about these forums...

[/quote]

[t3ckn0b0y]

a bunch of issues in the samples.. has anyone noticed them too..
lol...  input_token_bits duplicate port bits on a bunch of games..
alphamc07,bullfgtr,bullfgts,equites,equitess,gekisou,hvoltage,kouyakyu,
splndrbt   ...   all associated with bongo1 - bongo3.wav files.. LOL..

[ryguy]

Hi, hope somebody can help, I think I've followed it all to the letter.  I've downloaded 0.125 source code, tried to patch in the hi_125.diff and get the following messages: -

c:\mamesrc>patchmame hi_125

c:\mamesrc>patch -p0 -E  0<hi_125.diff
patching file src/emu/cheat.c
patching file src/emu/cheat.h
patching file src/emu/crsshair.c
patching file src/emu/emu.mak
patching file src/emu/emuopts.c
patching file src/emu/emuopts.h
patching file src/emu/fileio.h
patching file src/emu/hiscore/c
patch unexpectedly ends in middle of line
patch: **** unexpected end of file in patch

c:\mamesrc>


I've tried patching in u1, u2 etc - which works fine, but same thing happens when i try the u2 hi_score file etc.  I've also tried patching it in as a txt file as previously suggested, but again same thing.  Can't understand what I've done wrong as re-read instruction number of times?

Any help would be greatly appreciated!!


LATEST - Tried using hi_124 with 125 source code, and for some reason it patched in ok?  Compiling now to see if it all works - any idea why hi_124 would patch in and not hi_125?

[MKChamp]

Hi, hope somebody can help, I think I've followed it all to the letter.  I've downloaded 0.125 source code, tried to patch in the hi_125.diff and get the following messages: -

c:\mamesrc>patchmame hi_125

c:\mamesrc>patch -p0 -E  0<hi_125.diff
patching file src/emu/cheat.c
patching file src/emu/cheat.h
patching file src/emu/crsshair.c
patching file src/emu/emu.mak
patching file src/emu/emuopts.c
patching file src/emu/emuopts.h
patching file src/emu/fileio.h
patching file src/emu/hiscore/c
patch unexpectedly ends in middle of line
patch: **** unexpected end of file in patch

c:\mamesrc>


I've tried patching in u1, u2 etc - which works fine, but same thing happens when i try the u2 hi_score file etc.  I've also tried patching it in as a txt file as previously suggested, but again same thing.  Can't understand what I've done wrong as re-read instruction number of times?

Any help would be greatly appreciated!!


LATEST - Tried using hi_124 with 125 source code, and for some reason it patched in ok?  Compiling now to see if it all works - any idea why hi_124 would patch in and not hi_125?

Did you copy and paste the stuff in red or type it out. The reason I ask is because:
patching file src/emu/hiscore/c
That should be patching file src/emu/hiscore.c

At any rate, I would re-download the hi_125 file and open it up in notepad and see if it looks ok. May have been a corrupt download. Try that and let me know what you find and we can go from there....

[ryguy]

Hi, thanks for helping, yes, I did type that out in red - couldn't work out how to copy the text on the command prompt into this forum, so that line was my error.

I've opened up the hi_125 file and although a lot is unfamiliar, it doesn't look corrupted, however it's odd it did the same when I used a later version as well.  I can try downloading it again.

I thought all was going to be ok with the hi_124 version (with the 125 source) - however for some reason I got errors on the compiling and the files were not created - maybe there's some conflict as I'm using the 124 version.

Will try downloading hi_125 again and see if it works.......

 LASTEST - Patch worked ok!  I downloaded it again - and also used the full zip file for the 0.125 source, rather than the .exe file - don't know if that made a difference.  Will now try the compiler again - fingers crossed!  Thanks for your help so far......will keep you updated!

[ryguy]

 

It's worked!  Thanks MKChamp - must have been a dodgey download - high scores work on all my favourites, so great news.  This is a fantastic patch as I think it's vital to an arcade machine to have the high scores saved, don't know why they took it out off in the first place, thanks for posting this and the help,

Cheers,

[9innail]

Hi,
Are we going to get a new diff soon.Thanks.

[MKChamp]

No need for a new diff...hi_125u4 works perfectly for 125u5. You will get some messages while patching because the lines don't match up perfectly...but it still patches...so, patch away!

[Jdurg]

It's worked!  Thanks MKChamp - must have been a dodgey download - high scores work on all my favourites, so great news.  This is a fantastic patch as I think it's vital to an arcade machine to have the high scores saved, don't know why they took it out off in the first place, thanks for posting this and the help,

Cheers,

Yes, it is an awesome patch.  The reason it's not in MAME is that real arcade machines typically did not retain their high scores when they were turned off.  If the power went out, the high scores went with it.  When you exit the emulator in MAME, you are effectively turning the power off on the machine.  The games that did save their high scores when the power was turned off still do retain the scores in MAME.

[headkaze]

The games that did save their high scores when the power was turned off still do retain the scores in MAME.

I'm curious does the new "save state" feature of Mame only support games that retained hiscores on power off or are they planning on adding support for all games eventually? I thought their goal was to add save state for all games?

[Jdurg]

It will, eventually maybe, be there for all games.  The Save State feature is great for development and bug-testing purposes.  The games that in the arcades actually saved high scores did so in the nvram.  So in MAME, the nvram file will hold the high scores and not the hacked hiscore.dat method.

[FrizzleFried]

No need for a new diff...hi_125u4 works perfectly for 125u5. You will get some messages while patching because the lines don't match up perfectly...but it still patches...so, patch away!

I am considering doing the .126 upgrade.  Compatible?

Thanks!

[TheShanMan]

Patch seems to install fine. I'd say yes, though my compile hasn't finished yet.

EDIT: Build completed without errors.

[RoomTenONine]

Quick noobish question.  I just compiled my first MAME build today.  All went VERY well thanks to the two great tutorials here 

One issue: The link to hiscore.dat is broken.  I also see from the mameworld.info forums that it isn't supported in MAME any more as they see it as a hack.  Now I have a version of hiscore.dat from 2006 (came with my previously used advanceMAME files).  However I know tehre is a newer version released not long ago in 2008.  That's what I'm after.

TIA

[MKChamp]

Quick noobish question.  I just compiled my first MAME build today.  All went VERY well thanks to the two great tutorials here 

One issue: The link to hiscore.dat is broken.  I also see from the mameworld.info forums that it isn't supported in MAME any more as they see it as a hack.  Now I have a version of hiscore.dat from 2006 (came with my previously used advanceMAME files).  However I know tehre is a newer version released not long ago in 2008.  That's what I'm after.

TIA

Mameworld had some issues...but they are back up now. Go grab that hiscore dat file :-)

[RoomTenONine]

Got it, thanks.  All is good in the world.

[Teknique]

just posting my thanks MKChamp for your work on this.  It is appreciated!

Tek

[Todd H]

Thanks for all the hard work! I compiled my own mame using your diff and it works like a charm.

Any chance we can get the -ssf (skip startup frames) option added? Thanks again.

[cadmium]

Does this patch work with CPS3 games?

[SGT]

You can search the contents of hiscore.dat to determine which roms are supported.

[retrometro]

I don't want to cross post but I thought this problem is a related heavily to the actual hiscore diff patch itself.  Basically after using headkaze's compile helper, 32bit hi_126 patched mame reads/writes hiscore game files fine while 64bit runs fine but does not read/write hiscore game files.

http://forum.arcadecontrols.com/index.php?topic=71845.msg874464#msg874464

Anyone else observed this behavior?  Thanks!

[lettuce]

Ok a bit of an update of the hiscore problem with 64bit mame. I tried the hiscore diff that comes with SailorSats cabmame complie, and i just applied that hiscore diff (this doesnt include the no nag screen like the hiscore.diff in this thread), and hiscore works with SailorSat hiscore diff. I then recomplied mame 0.127 with the hiscore diff from this thread and it didnt work again! So i beleive theres something wrong with the hiscore diff thats supplied in this thread, i dont thinks its the highscore support itself but something to do with the removeal of the no nag screen maybe??

[retrometro]

Ok a bit of an update of the hiscore problem with 64bit mame. I tried the hiscore diff that comes with SailorSats cabmame complie, and i just applied that hiscore diff (this doesnt include the no nag screen like the hiscore.diff in this thread), and hiscore works with SailorSat hiscore diff. I then recomplied mame 0.127 with the hiscore diff from this thread and it didnt work again! So i beleive theres something wrong with the hiscore diff thats supplied in this thread, i dont thinks its the highscore support itself but something to do with the removeal of the no nag screen maybe??

Rock on Lettuce (and SailorSat)!!!!

I just recompiled with a clean source and patched just SailorSat's hiscore diff and all 64bit mame is working with hiscores again.   Woo hoo!

I've minimized some of the nagging with mame's -skip_gameinfo but other things still pop up so it would be awesome if this msg thread's hiscore + nonag diff got fixed for 64bit.

As a suggestion though, I really like how SailorSat separates each of her hacks into its own diff file so you can pick and choose which one you want.  Plus on top of that, she allows at least 3 of her hacks to be turned off and on via mame.ini even if you patched them anyways.  Not only does that relieves you from having to have multiple mame.exe's floating around but you can tailor each hack in each game's own ini if you want.

[MKChamp]

Ok...can one of you guys re-download the 127 diff and see if it now works on your 64 bit machine. Make sure when you download it it is the latest and not cached on your machine. The third line should have a time stamp like this:
+++ src/emu/cheat.c   2008-08-23 20:17:40.000000000 -0500

Post back and let me know if it worked or not. Gracias!

[retrometro]

Ok...can one of you guys re-download the 127 diff and see if it now works on your 64 bit machine. Make sure when you download it it is the latest and not cached on your machine. The third line should have a time stamp like this:
+++ src/emu/cheat.c   2008-08-23 20:17:40.000000000 -0500

Post back and let me know if it worked or not. Gracias!

De nada!  What great support!  I've just tried your new 127 diff for a 64bit compile and hiscores are working again.  What did you change?

Also, I applied your 127 diff to my 126 source.  Do I need an updated 126 from you also?  What are the consequence(s) if any?

[headkaze]

Thanks MKChamp

[TheShanMan]

As a suggestion though, I really like how SailorSat separates each of her hacks into its own diff file so you can pick and choose which one you want.  Plus on top of that, she allows at least 3 of her hacks to be turned off and on via mame.ini even if you patched them anyways.  Not only does that relieves you from having to have multiple mame.exe's floating around but you can tailor each hack in each game's own ini if you want.

I asked for separate diff's a while back, and the suggestion was that you can search the diff and take out what you don't want easily. I've been doing this lately (I like the basic startup messages "Initializing" but I hate seeing "Decoding (57%)" and stuff like that. Well, it's not exactly trivial (and I'm a software engineer!). So I'd like to second this request! How about zipping up separate diff files so there's one download but multiple diff's?

[retrometro]

I asked for separate diff's a while back, and the suggestion was that you can search the diff and take out what you don't want easily. I've been doing this lately (I like the basic startup messages "Initializing" but I hate seeing "Decoding (57%)" and stuff like that. Well, it's not exactly trivial (and I'm a software engineer!). So I'd like to second this request! How about zipping up separate diff files so there's one download but multiple diff's?

Here's how SailorSat separates her diffs in her "cabmame" bundle.  In addition, she hosts 32bit and 64bit compiles of mame and mameui with all the patches. 

-rwxr-xr-x@ 1 root  admin   5656 Aug 21 19:24 0127_changeres.diff
-rwxr-xr-x@ 1 root  admin   6137 Aug 21 19:23 0127_cleanstretch.diff
-rwxr-xr-x@ 1 root  admin   4424 Aug 21 19:22 0127_defaults.diff
-rwxr-xr-x@ 1 root  admin    994 Aug 21 19:23 0127_emuspeed.diff
-rwxr-xr-x@ 1 root  admin    484 Aug 21 19:29 0127_frogger.diff
-rwxr-xr-x@ 1 root  admin  13639 Aug 21 19:25 0127_hiscore.diff
-rwxr-xr-x@ 1 root  admin   3787 Aug 21 19:28 0127_redraw.diff
-rwxr-xr-x@ 1 root  admin   1386 Aug 21 19:29 0127_resolution.diff
-rwxr-xr-x@ 1 root  admin   1132 Aug 21 19:27 0127_soundsync.diff

Anyway, MKChamp, I really appreciate your work updating and answering support questions in this thread.