hiscore diff (with no nag/white box removal)

[headkaze]

The patch did not work using MAME compiler. When I patched it manually using the buildtools command line, it worked flawlessly ![/b]

I changed the default -p option to work with the new feature to create patches. If MKChamp used MAME Compiler to create the patch then there wouldn't be a problem as the -p options would match.

I think I'm going to have to add a manual -p setting to MAME Compiler as there doesn't seem to be a setting that will work with all patches.

[Ginsonic]

I changed the default -p option to work with the new feature to create patches. If MKChamp used MAME Compiler to create the patch then there wouldn't be a problem as the -p options would match.

I think I'm going to have to add a manual -p setting to MAME Compiler as there doesn't seem to be a setting that will work with all patches.

Thanks for the info Headkaze !

[fleskebacon]

Hi all, I've been using these diffs since like forever.

Lately, I'm having issues with artwork when using the patched and compiled Mame64.exe.

What happens is, that when I set video mode to standard 4:3 without any artwork, it saves this option one time, but then removes the lines from the .cfg file and at the next start, the game is back to default, which is usually not 4:3 but some artwork option that I obviously don't want as default.

Regular Mame not patched works fine.

Any options or anything new I've missed, or is anybody else also having this?

[ozfalcon]

Hi all, I've been using these diffs since like forever.

Lately, I'm having issues with artwork when using the patched and compiled Mame64.exe.

What happens is, that when I set video mode to standard 4:3 without any artwork, it saves this option one time, but then removes the lines from the .cfg file and at the next start, the game is back to default, which is usually not 4:3 but some artwork option that I obviously don't want as default.

Regular Mame not patched works fine.

Any options or anything new I've missed, or is anybody else also having this?

I am unable to reproduce this behaviour on SDL/Linux.
Which Mame version are you experiencing this problem?

[fleskebacon]

Hi all, I've been using these diffs since like forever.

Lately, I'm having issues with artwork when using the patched and compiled Mame64.exe.

What happens is, that when I set video mode to standard 4:3 without any artwork, it saves this option one time, but then removes the lines from the .cfg file and at the next start, the game is back to default, which is usually not 4:3 but some artwork option that I obviously don't want as default.

Regular Mame not patched works fine.

Any options or anything new I've missed, or is anybody else also having this?

I am unable to reproduce this behaviour on SDL/Linux.
Which Mame version are you experiencing this problem?

I'm using Windows 7 64-bit, same thing happens in both 0173 and 0175. Haven't tested 0174. I think the issue started with 0173, but I'm not sure.

[ozfalcon]

Hi all, I've been using these diffs since like forever.

Lately, I'm having issues with artwork when using the patched and compiled Mame64.exe.

What happens is, that when I set video mode to standard 4:3 without any artwork, it saves this option one time, but then removes the lines from the .cfg file and at the next start, the game is back to default, which is usually not 4:3 but some artwork option that I obviously don't want as default.

Regular Mame not patched works fine.

Any options or anything new I've missed, or is anybody else also having this?

I am unable to reproduce this behaviour on SDL/Linux.
Which Mame version are you experiencing this problem?

I'm using Windows 7 64-bit, same thing happens in both 0173 and 0175. Haven't tested 0174. I think the issue started with 0173, but I'm not sure.

I can reproduce the problem.
ONLY the "view=" gets removed on subsequent runs.

As a workaround - Use an artwork lay file defining your video mode.
This may take some time to get fixed (GroovyMame may be suffering the same problem - It uses almost identical mechanism)

The problem I believe is the suppression of the loading patch.
Reference:
http://forum.arcadecontrols.com/index.php/topic,64298.msg1434501.html#msg1434501

[kaptainsteve]

Hiscore saving and no nag is included in the plugin option in all Mames now after 174....

[ozfalcon]

Hiscore saving and no nag is included in the plugin option in all Mames now after 174....

What is the no nag option to disable the "There are known problems with this machine", White borders and loading messages.....?

The hiscore plugin appears to be fine, But the plugins function still requires bug fixes and the like - Though it is still perfectly usable.

[ozfalcon]

Hi all, I've been using these diffs since like forever.

Lately, I'm having issues with artwork when using the patched and compiled Mame64.exe.

What happens is, that when I set video mode to standard 4:3 without any artwork, it saves this option one time, but then removes the lines from the .cfg file and at the next start, the game is back to default, which is usually not 4:3 but some artwork option that I obviously don't want as default.

Regular Mame not patched works fine.

Any options or anything new I've missed, or is anybody else also having this?

Thanks for posting 

I have moved the "loading" messages patch, The game.cfg issue is resolved.

However, There may be unforeseen consequences........... Like other expected messages not showing.

 So now would be a good time to give it a thorough testing.

Update: Patch hi_175b.txt removed, Use hi_175c.txt in the next post.

[ozfalcon]

One unforeseen consequence has been found.
If using  "-confirm_quit" then the exit dialog is clobbered.

This patch fixes the "-confirm_quit" dialog (And possibly others).

New (hi_175c.txt) patch still needs a thorough testing.

[cugel]

One unforeseen consequence has been found.
If using the -confirm_quit then the exit dialog is clobbered.

This patch fixes the -confirm_quit dialog.

New (hi_175c.txt) patch still needs a thorough testing.
(ie. Make sure all INITIALIZING, LOADING & DECRYPTING MESSAGES are suppressed).

Tested on linux xubuntu 16.04, mame works good but I have a problem with my previous high score, maybe I missed something ?

hi directory in mame directory
highscore.dat in mame directory
disable_highscore_patch removed from mame.ini
hiscore_directory         $HOME/.mame/hi added in mame.ini

But now there is no high score in game

[hsialin]

HeadKaze we need you bad man.

[ozfalcon]

One unforeseen consequence has been found.
If using the -confirm_quit then the exit dialog is clobbered.

This patch fixes the -confirm_quit dialog.

New (hi_175c.txt) patch still needs a thorough testing.
(ie. Make sure all INITIALIZING, LOADING & DECRYPTING MESSAGES are suppressed).

Tested on linux xubuntu 16.04, mame works good but I have a problem with my previous high score, maybe I missed something ?

hi directory in mame directory
highscore.dat in mame directory
disable_highscore_patch removed from mame.ini
hiscore_directory         $HOME/.mame/hi added in mame.ini

But now there is no high score in game

These changes do not affect the hiscore code, So it's likely something your doing differently.
You need to be sure you start Mame in the same directory as the hiscore.dat
You also need to use the MKChamp hiscore.dat (Not the one supplied with Mame.zip)
 http://highscore.mameworld.info/download.htm

Also ensure you have the Lua script version of hiscore disabled.

[cugel]

These changes do not affect the hiscore code, So it's likely something your doing differently.
You need to be sure you start Mame in the same directory as the hiscore.dat
You also need to use the MKChamp hiscore.dat (Not the one supplied with Mame.zip)
 http://highscore.mameworld.info/download.htm

Also ensure you have the Lua script version of hiscore disabled.

Yes right, now I remember that http://forum.arcadecontrols.com/index.php/topic,64298.msg1440381.html#msg1440381
I will make a try thanks

[cugel]

These changes do not affect the hiscore code, So it's likely something your doing differently.
You need to be sure you start Mame in the same directory as the hiscore.dat
You also need to use the MKChamp hiscore.dat (Not the one supplied with Mame.zip)
 http://highscore.mameworld.info/download.htm

Also ensure you have the Lua script version of hiscore disabled.

Yes right, now I remember that http://forum.arcadecontrols.com/index.php/topic,64298.msg1440381.html#msg1440381
I will make a try thanks

Ok it's good I added a path in source code
I guess hiscore.dat in hi directory, by default, should be a more logical/practical way ...

[ozfalcon]

These changes do not affect the hiscore code, So it's likely something your doing differently.
You need to be sure you start Mame in the same directory as the hiscore.dat
You also need to use the MKChamp hiscore.dat (Not the one supplied with Mame.zip)
 http://highscore.mameworld.info/download.htm

Also ensure you have the Lua script version of hiscore disabled.

Yes right, now I remember that http://forum.arcadecontrols.com/index.php/topic,64298.msg1440381.html#msg1440381
I will make a try thanks

Ok it's good I added a path in source code
I guess hiscore.dat in hi directory, by default, should be a more logical/practical way ...

Yes, It is more convenient to have hiscore.dat coupled with the hi score directory.
However, The HiScore component of this patch is MKChamps expertise - So I don't modify it at all.

I do use the same method, But rather than modifying the source - I just patch the HiScore patch.
ie. Apply the HiScore patch then apply the HiDatDirectory patch (Attached) and your hiscore.dat will be looked for in the "hi" directory.

<Also added current hi_175c.txt for convenience>

[cugel]

Yes I did the same thing, hope I will not forget the next time

[fleskebacon]

Hiscore saving and no nag is included in the plugin option in all Mames now after 174....

What is the no nag option to disable the "There are known problems with this machine", White borders and loading messages.....?

The hiscore plugin appears to be fine, But the plugins function still requires bug fixes and the like - Though it is still perfectly usable.

I've been using the hiscore plugin for some time now, and as you say - it seems to be working fine, at least in all games I've played.

Worth to mention that the MKChamp hiscore patch and the Mame plugin use different formats of the hiscore.dat file... I sure spent some frustrating time before discovering this.

I also found some old code for supressing the white box and all loading messages, it seems to work fine with the recent Mame versions as well. Could very well be the same code used in this diff for all I know, but at first glance it seems to do it in a different way. My programming skills are absolutely rubbish, so I barely have a clue of what I'm doing... However, I managed to manually patch render.cpp and ui.cpp using the code I found, so now I have a nag-free Mame without added hiscore support, and using the Mame hiscore plugin.

Could very well turn out to be problems with this approach, but so far so good. Will check back later with an update on this.

[ozfalcon]

Hiscore saving and no nag is included in the plugin option in all Mames now after 174....

What is the no nag option to disable the "There are known problems with this machine", White borders and loading messages.....?

The hiscore plugin appears to be fine, But the plugins function still requires bug fixes and the like - Though it is still perfectly usable.

I've been using the hiscore plugin for some time now, and as you say - it seems to be working fine, at least in all games I've played.

Worth to mention that the MKChamp hiscore patch and the Mame plugin use different formats of the hiscore.dat file... I sure spent some frustrating time before discovering this.

I also found some old code for supressing the white box and all loading messages, it seems to work fine with the recent Mame versions as well. Could very well be the same code used in this diff for all I know, but at first glance it seems to do it in a different way. My programming skills are absolutely rubbish, so I barely have a clue of what I'm doing... However, I managed to manually patch render.cpp and ui.cpp using the code I found, so now I have a nag-free Mame without added hiscore support, and using the Mame hiscore plugin.

Could very well turn out to be problems with this approach, but so far so good. Will check back later with an update on this.

The suppression code is right at the end of the hiscore patch - The entire lot can be easily removed to be standalone.

[Sorn]

The patch did not work using MAME compiler. When I patched it manually using the buildtools command line, it worked flawlessly ![/b]

I changed the default -p option to work with the new feature to create patches. If MKChamp used MAME Compiler to create the patch then there wouldn't be a problem as the -p options would match.

I think I'm going to have to add a manual -p setting to MAME Compiler as there doesn't seem to be a setting that will work with all patches.

I would like to get 0175 compiled with the hi score patch, is there currently any work around (such as a diff patching util) or do we need to wait for your update headkaze?

Thank you!

[abelenki]

I would like to get 0175 compiled with the hi score patch, is there currently any work around (such as a diff patching util) or do we need to wait for your update headkaze?

LOL.

[ppv]

http://www.hyperspin-fe.com/files/download/11913-mame-64bit-nonag-hi-score-raw-input/

you'll need an account of the Hyperspin forum though...

[Sorn]

I am running into the same problem, although I am using the command line environment (windows/64) and its still throwing the same error with 0175. Could someone please explain the correct syntax to get beyond this error? I understand that mame has officially added support, though I am more interested in fully removing nag screens, which official mame currently does not offer, and this patch does.

thank you.

Unfortunately the new patch is not working for me with MAME version 175:

Log:

Testing Diff Patch...
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Nru old/emu/emuopts.cpp src/emu/emuopts.cpp
|--- old/emu/emuopts.cpp   2016-06-29 03:04:14.753317700 -0500
|+++ src/emu/emuopts.cpp   2016-06-29 09:36:42.863647400 -0500
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 28
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
Finished!
0 Hours 0 Minutes and 0 Seconds Elapsed.
|diff -Nru old/emu/emuopts.h src/emu/emuopts.h


Update:

The patch did not work using MAME compiler. When I patched it manually using the buildtools command line, it worked flawlessly !

[ozfalcon]

I am running into the same problem, although I am using the command line environment (windows/64) and its still throwing the same error with 0175. Could someone please explain the correct syntax to get beyond this error? I understand that mame has officially added support, though I am more interested in fully removing nag screens, which official mame currently does not offer, and this patch does.

thank you.

Unfortunately the new patch is not working for me with MAME version 175:

Log:

Testing Diff Patch...
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Nru old/emu/emuopts.cpp src/emu/emuopts.cpp
|--- old/emu/emuopts.cpp   2016-06-29 03:04:14.753317700 -0500
|+++ src/emu/emuopts.cpp   2016-06-29 09:36:42.863647400 -0500
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 28
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
Finished!
0 Hours 0 Minutes and 0 Seconds Elapsed.
|diff -Nru old/emu/emuopts.h src/emu/emuopts.h


Update:

The patch did not work using MAME compiler. When I patched it manually using the buildtools command line, it worked flawlessly !

Are you using the official build tools environment, Not the standard windows command line environment?
http://mamedev.org/tools/

[Sorn]

I am running into the same problem, although I am using the command line environment (windows/64) and its still throwing the same error with 0175. Could someone please explain the correct syntax to get beyond this error? I understand that mame has officially added support, though I am more interested in fully removing nag screens, which official mame currently does not offer, and this patch does.

thank you.

Unfortunately the new patch is not working for me with MAME version 175:

Log:

Testing Diff Patch...
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Nru old/emu/emuopts.cpp src/emu/emuopts.cpp
|--- old/emu/emuopts.cpp   2016-06-29 03:04:14.753317700 -0500
|+++ src/emu/emuopts.cpp   2016-06-29 09:36:42.863647400 -0500
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 28
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
Finished!
0 Hours 0 Minutes and 0 Seconds Elapsed.
|diff -Nru old/emu/emuopts.h src/emu/emuopts.h


Update:

The patch did not work using MAME compiler. When I patched it manually using the buildtools command line, it worked flawlessly !

Are you using the official build tools environment, Not the standard windows command line environment?
http://mamedev.org/tools/

I am. Using the msys64 in console (win32con.bat) with the patching software updated (pacman --needed -Sy patch) and the following syntax
patch --binary -p0 -E <C:\msys32\hi_175.diff

Which results in the same error as the other user had, which I quoted.

Thank you for your response. I can compile 0175 no problem, just cant apply patch.

[abelenki]

I am. Using the msys64 in console (win32con.bat) with the patching software updated (pacman --needed -Sy patch) and the following syntax
patch --binary -p0 -E <C:\msys32\hi_175.diff

Which results in the same error as the other user had, which I quoted.

MKChamp's hi_175.diff should be applied without --binary parameter:

Code: [Select]

patch -p0 -E < hi_175.diff

[ozfalcon]

I just loaded up Windows/msys64 (Full console).

Updated the msys64 environment.

Unpacked Mame 0.175 (Twice).

Applied the patch with --binary and it worked without any errors or warnings.
 patch --binary -p0 -E <../hi_175.txt

Applied the patch without --binary and it complained about trailing CR/LF (Still appeared to work).
 patch -p0 -E <../hi_175.txt

Are you sure you are applying the patch from the correct location?

[ozfalcon]

Just to note, There has been a bug fix and you probably want to be using hi_175c.txt
You will also more than likely need to patch hi_175c.txt with the --binary flag.

This post has the fixed revision
http://forum.arcadecontrols.com/index.php/topic,64298.msg1579630.html#msg1579630

[Sorn]

Just to note, There has been a bug fix and you probably want to be using hi_175c.txt
You will also more than likely need to patch hi_175c.txt with the --binary flag.

This post has the fixed revision
http://forum.arcadecontrols.com/index.php/topic,64298.msg1579630.html#msg1579630

Using hi_175c with the --binary flag worked thanks!

[Sorn]

Just to note, There has been a bug fix and you probably want to be using hi_175c.txt
You will also more than likely need to patch hi_175c.txt with the --binary flag.

This post has the fixed revision
http://forum.arcadecontrols.com/index.php/topic,64298.msg1579630.html#msg1579630

Using hi_175c with the --binary flag worked thanks!

Hah, spoke too soon! Patching works but compiling does not?

make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hisc
ore.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
Compiling src/devices/cpu/sh2/sh2dasm.cpp...

...continues compiling...

makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
make[1]: *** Waiting for unfinished jobs....
Compiling src/mame/audio/targ.cpp...

...continues compiling....then gets to

Compiling src/devices/cpu/tms57002/57002dsm.cpp...
Archiving libdasm.a...
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Any idea? 

[ozfalcon]

Just to note, There has been a bug fix and you probably want to be using hi_175c.txt
You will also more than likely need to patch hi_175c.txt with the --binary flag.

This post has the fixed revision
http://forum.arcadecontrols.com/index.php/topic,64298.msg1579630.html#msg1579630

Using hi_175c with the --binary flag worked thanks!

Hah, spoke too soon! Patching works but compiling does not?

make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hisc
ore.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
Compiling src/devices/cpu/sh2/sh2dasm.cpp...

...continues compiling...

makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
make[1]: *** Waiting for unfinished jobs....
Compiling src/mame/audio/targ.cpp...

...continues compiling....then gets to

Compiling src/devices/cpu/tms57002/57002dsm.cpp...
Archiving libdasm.a...
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Any idea? 

How are you compiling?

Sometimes compile will fail with -j3 (The number of jobs option).
The load option may help if this is a persistent issue on your machine when using the -j option.
Read this: https://www.gnu.org/software/make/manual/make.html#Parallel

If you restart the compile, It should continue and finish.

[brucelee00]

Can someone explain how you and where you exactly apply the patch with binary ? I have tried using the hi_175.txt with the same errors above I have used hi_175c.txt with the same errors... how and where am i suppose to be applying these patches ? I am just using Mamecompiler 64> apply patch option to apply the patch. Thanks for the help in advance

[Sorn]

Just to note, There has been a bug fix and you probably want to be using hi_175c.txt
You will also more than likely need to patch hi_175c.txt with the --binary flag.

This post has the fixed revision
http://forum.arcadecontrols.com/index.php/topic,64298.msg1579630.html#msg1579630

Using hi_175c with the --binary flag worked thanks!

Hah, spoke too soon! Patching works but compiling does not?

make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hisc
ore.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
Compiling src/devices/cpu/sh2/sh2dasm.cpp...

...continues compiling...

makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
make[1]: *** Waiting for unfinished jobs....
Compiling src/mame/audio/targ.cpp...

...continues compiling....then gets to

Compiling src/devices/cpu/tms57002/57002dsm.cpp...
Archiving libdasm.a...
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Any idea? 

How are you compiling?

Sometimes compile will fail with -j3 (The number of jobs option).
The load option may help if this is a persistent issue on your machine when using the -j option.
Read this: https://www.gnu.org/software/make/manual/make.html#Parallel

If you restart the compile, It should continue and finish.

Yes, I thought it might be the -j option, so I did a make clean and then started fresh with a new make and it got similar errors.

Compiling src/emu/hashfile.cpp...
make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hiscore.o'.  Stop.
makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

[ozfalcon]

Just to note, There has been a bug fix and you probably want to be using hi_175c.txt
You will also more than likely need to patch hi_175c.txt with the --binary flag.

This post has the fixed revision
http://forum.arcadecontrols.com/index.php/topic,64298.msg1579630.html#msg1579630

Using hi_175c with the --binary flag worked thanks!

Hah, spoke too soon! Patching works but compiling does not?

make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hisc
ore.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
Compiling src/devices/cpu/sh2/sh2dasm.cpp...

...continues compiling...

makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
make[1]: *** Waiting for unfinished jobs....
Compiling src/mame/audio/targ.cpp...

...continues compiling....then gets to

Compiling src/devices/cpu/tms57002/57002dsm.cpp...
Archiving libdasm.a...
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Any idea? 

How are you compiling?

Sometimes compile will fail with -j3 (The number of jobs option).
The load option may help if this is a persistent issue on your machine when using the -j option.
Read this: https://www.gnu.org/software/make/manual/make.html#Parallel

If you restart the compile, It should continue and finish.

Yes, I thought it might be the -j option, so I did a make clean and then started fresh with a new make and it got similar errors.

Compiling src/emu/hashfile.cpp...
make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hiscore.o'.  Stop.
makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Thats odd. I just compiled with no errors on a Windows 7 64 bit machine.

1.Unpacked the Mame0175.zip (In windows).
2.Patched the source (In msys64).
3.Compiled the source (In msys64).

Patch command was
patch --binary -p0 -E <../hi_175c.txt

Compile command was
make SUBTARGET=arcade -j3

Looking at the error, It seems hiscore.cpp is missing.
Have you checked to see if the hiscore.cpp file is being created at /src/emu/hiscore.cpp after the patch is applied?

Could be something to do with directory permissions, ie. The patch is creating a new file (hiscore.cpp).
All the other files are "Modified" in the patch.

[ozfalcon]

MKChamp & Abelenki & Everyone - Discussion.

The current (Non Lua) hiscore.dat is dated 1/7/2015.
I have noticed various corrections to the Lua hiscore.dat file.
https://github.com/mamedev/mame/commits/3f58aa4548327df4a6223ed7bf84e614c2cb12e7/plugins/hiscore/hiscore.dat
  https://github.com/mamedev/mame/commit/3f58aa4548327df4a6223ed7bf84e614c2cb12e7
  https://github.com/mamedev/mame/commit/f9b5a025a5477e115b461dfacfdb86c675d2945e
  https://github.com/mamedev/mame/commit/249e77583e31dcfb598f33c4ec523abd1430be02
  https://github.com/mamedev/mame/commit/07f297ae7ab41b69df9859cf48a5af3681113dec
  https://github.com/mamedev/mame/commit/d63cd99bc30e8bb71e4774c17d488f03482071c2

Something to consider, Though I'm not sure it has much impact on the Majority of games in the existing MKChamp hiscore.dat.
(This is NOT a call to update the MKChamp hiscore.dat)

[brucelee00]

I guess I am confused by this whole work around. I am used to using Mame Compiler 64 out of the box. I would normally run the program download the latest Mame source files in this case Mame Compiler 64 download list has not been updated to pull the latest sources so, I downloaded the msys64-32-2016-02-16.exe from Mame. Download the mame0175s.zip  unzip 2 times and put the files in the src folder> download hi_175.txt and put that in the patches folder. Where I am getting a bunch of errors is when applying the hi_175.txt patch when I normally don't have these issues. 

Here is the error I get when I apply the hi_175.txt patch

Applying Diff Patch...
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Nru old/emu/emuopts.cpp src/emu/emuopts.cpp
Finished!
0 Hours 0 Minutes and 0 Seconds Elapsed.
|--- old/emu/emuopts.cpp   2016-06-29 03:04:14.753317700 -0500

This is the error I get when I apply the hi_175c.txt

Applying Diff Patch...
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
Assertion failed: hunk, file patch-2.5.4/patch.c, line 343
The text leading up to this was:
--------------------------
This application has requested the Runtime to terminate it in an unusual way.
|diff -Nru old/emu/emuopts.cpp src/emu/emuopts.cpp
Please contact the application's support team for more information.
|--- old/emu/emuopts.cpp   2016-06-29 18:04:14.000000000 +1000
|+++ src/emu/emuopts.cpp   2016-07-05 15:20:25.328062487 +1000
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 28
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Nru old/emu/emuopts.h src/emu/emuopts.h
|--- old/emu/emuopts.h   2016-06-29 18:04:14.000000000 +1000
|+++ src/emu/emuopts.h   2016-07-05 15:20:25.328062487 +1000
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 57 of patch
can't find file to patch at input line 57
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|@ -231,6 +236,9 @@
|    const char *snapshot_directory() const { return value(OPTION_SNAPSHOT_DIRECTORY); }
|    const char *diff_directory() const { return value(OPTION_DIFF_DIRECTORY); }
|    const char *comment_directory() const { return value(OPTION_COMMENT_DIRECTORY); }
|+   
|+   // MKCHAMP - hiscore directory options
|+   const char *hiscore_directory() const { return value(OPTION_HISCORE_DIRECTORY); }
|
|    // core state/playback options
|    const char *state() const { return value(OPTION_STATE); }
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
patching file emu/hiscore.cpp
Finished!
0 Hours 0 Minutes and 3 Seconds Elapsed.

[Sorn]

Just to note, There has been a bug fix and you probably want to be using hi_175c.txt
You will also more than likely need to patch hi_175c.txt with the --binary flag.

This post has the fixed revision
http://forum.arcadecontrols.com/index.php/topic,64298.msg1579630.html#msg1579630

Using hi_175c with the --binary flag worked thanks!

Hah, spoke too soon! Patching works but compiling does not?

make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hisc
ore.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
Compiling src/devices/cpu/sh2/sh2dasm.cpp...

...continues compiling...

makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
make[1]: *** Waiting for unfinished jobs....
Compiling src/mame/audio/targ.cpp...

...continues compiling....then gets to

Compiling src/devices/cpu/tms57002/57002dsm.cpp...
Archiving libdasm.a...
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Any idea? 

How are you compiling?

Sometimes compile will fail with -j3 (The number of jobs option).
The load option may help if this is a persistent issue on your machine when using the -j option.
Read this: https://www.gnu.org/software/make/manual/make.html#Parallel

If you restart the compile, It should continue and finish.

Yes, I thought it might be the -j option, so I did a make clean and then started fresh with a new make and it got similar errors.

Compiling src/emu/hashfile.cpp...
make[2]: *** No rule to make target '../../../../../src/emu/hiscore.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/emu/hiscore.o'.  Stop.
makefile:67: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Thats odd. I just compiled with no errors on a Windows 7 64 bit machine.

1.Unpacked the Mame0175.zip (In windows).
2.Patched the source (In msys64).
3.Compiled the source (In msys64).

Patch command was
patch --binary -p0 -E <../hi_175c.txt

Compile command was
make SUBTARGET=arcade -j3

Looking at the error, It seems hiscore.cpp is missing.
Have you checked to see if the hiscore.cpp file is being created at /src/emu/hiscore.cpp after the patch is applied?

Could be something to do with directory permissions, ie. The patch is creating a new file (hiscore.cpp).
All the other files are "Modified" in the patch.

You were correct, the hiscore.cpp was missing for some reason. Re-extracted the source from zip, re-patched, everything seemed ok. Did a make clean before a make with no -j switches just incase, and then ran into this -

make[2]: *** No rule to make target '../../../../../src/frontend/mame/ui/filecreate.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/frontend/mame/ui/filecreate.o'.  Stop.
makefile:73: recipe for target 'frontend' failed
make[1]: *** [frontend] Error 2
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Also is no filecreate.cpp in that dir. Checked source, not there either, is it supposed to create it somewhere in the process? There's always some snag waiting to trip me up haha

[ozfalcon]

You were correct, the hiscore.cpp was missing for some reason. Re-extracted the source from zip, re-patched, everything seemed ok. Did a make clean before a make with no -j switches just incase, and then ran into this -

make[2]: *** No rule to make target '../../../../../src/frontend/mame/ui/filecreate.cpp', needed by '../../../../mingw-gcc/obj/x64/Release/src/frontend/mame/ui/filecreate.o'.  Stop.
makefile:73: recipe for target 'frontend' failed
make[1]: *** [frontend] Error 2
makefile:947: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Also is no filecreate.cpp in that dir. Checked source, not there either, is it supposed to create it somewhere in the process? There's always some snag waiting to trip me up haha

No

Something wrong with your machine/HD. Have you tried on a different machine?

[ozfalcon]

I guess I am confused by this whole work around. I am used to using Mame Compiler 64 out of the box. I would normally run the program download the latest Mame source files in this case Mame Compiler 64 download list has not been updated to pull the latest sources so, I downloaded the msys64-32-2016-02-16.exe from Mame. Download the mame0175s.zip  unzip 2 times and put the files in the src folder> download hi_175.txt and put that in the patches folder. Where I am getting a bunch of errors is when applying the hi_175.txt patch when I normally don't have these issues. 

Here is the error I get when I apply the hi_175.txt patch

Applying Diff Patch...
can't find file to patch at input line 4

Your almost there.

That line "can't find file......" is the key to your answer - The patch can not find the files to "modify".
This means your not patching from the correct directory location.

You need to change directory to the "mame0175" folder then apply the patch.
Check you are in the correct directory with the "dir" or "ls" command and you should see the contents of the directory.

Code: [Select]

>dir
3rdparty bgfx   hlsl     LICENSE.md README.md  src
android-project  docs   ini     makefile regtests   tests
artwork doxygen  keymaps   nl_examples  samples    uismall.bdf
benchmarks hash   language  plugins scripts

If you copy the patch into the mame0175 directory then you apply it like this.
patch --binary -p0 -E <hi_175c.txt

[brucelee00]

here is a screen shot of all my paths within Mame Compiler 64 everything is exactly how I use to do it without issues.


As far as applying this patch --binary -p0 -E <C:\msys32\hi_175.diff  can someone elaborate the steps on this ?
am I supposed to do this in windows CMD ?

I never had to do any of these steps before I am use to just applying the patch within Mame compiler on the patch tab