hiscore diff (with no nag/white box removal)

[MKChamp]

hi_0169.diff doesn't work with 0.170 source tree, there are warnings and errors.

hi_170 patch has been uploaded. I haven't had a chance to compile with it yet, so if you find any issues, please let me know.

[reflex33]

I'm having a problem with the 170 patch...

Compiles just fine without the patch.  But with it we get errors.

[abelenki]

hi_170 patch has been uploaded. I haven't had a chance to compile with it yet, so if you find any issues, please let me know.

thanks!! it compiles fine.

[reflex33]

Ok so I saw that it compiled fine for other people... but I'm getting the following with the patch (without the patch it compiles fine):

Compiling src/osd/windows/window.cpp...
../../../../../src/osd/windows/window.cpp: In member function 'void win_window_info::update_hi()':
../../../../../src/osd/windows/window.cpp:863:34: error: 'osd_lock_acquire' was not declared in this scope
    osd_lock_acquire(m_render_lock);
                                  ^
../../../../../src/osd/windows/window.cpp:865:41: error: 'osd_lock_try' was not declared in this scope
    got_lock = osd_lock_try(m_render_lock);
                                         ^
../../../../../src/osd/windows/window.cpp:875:34: error: 'osd_lock_release' was not declared in this scope
    osd_lock_release(m_render_lock);
                                  ^
osd_windows.make:675: recipe for target '../../../../mingw-gcc/obj/x64/Release/osd_windows/src/osd/windows/window.o' failed
make[2]: *** [../../../../mingw-gcc/obj/x64/Release/osd_windows/src/osd/windows/window.o] Error 1
Makefile:19: recipe for target 'osd_windows' failed
make[1]: *** [osd_windows] Error 2
makefile:849: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

[abelenki]

hi_170.diff doesn't work with 0.171 source tree, there are warnings and errors.

currently, hi_171.diff can be downloaded from GroovyMAME thread.

[MKChamp]

hi_170.diff doesn't work with 0.171 source tree, there are warnings and errors.

currently, hi_171.diff can be downloaded from GroovyMAME thread.

Sorry for the delay. My PC where I do all the code and compile bit the dust and I lost everything. I've uploaded the 171 patch...have fun!

[abelenki]

Sorry for the delay. My PC where I do all the code and compile bit the dust and I lost everything. I've uploaded the 171 patch...have fun!

thanks, MKChamp!

[Stiletto]

Hi guys,

You may have heard of this new development:
https://github.com/cracyc/mame-hiscores

Description thread at MAMEWorld:
http://www.mameworld.info/ubbthreads/showflat.php?Cat=&Number=351252

I talked to MKChamp about this new development and he says in light of this, so long as the new script is as bug free as the previous hiscore.dat patch, he may discontinue hiscore.dat sourcecode patch maintenance in the future in favor of this script that does not require recompiling MAME.

MAMEdev is hoping that this and other scripts like it are the beginning of a thriving third-party Lua script community. We can't wait to see how other enthusiasts use this new feature.

It should be ready to go officially when MAME 0.172 hits, but you can take it for a test drive now if you can compile latest GIT.

Cheers!

[sean_sk]

Thanks for the info, it looks promising.

For the time being though, I think I'll stick with the hiscore diff. Time has proven it's reliability and a significant amount of time needs to pass to prove the new lua hi score script is reliable and mature enough before I'll change over. I'm always open to being convinced otherwise.

The other concern is if the new hi score script removes nag screens or if anyone is developing a script for that. I have a cabinet setup with Hyperspin shelled to hide Windows and dont want nag screens since it kinda ruins the effect I'm going for, that is, the feel of a real arcade machine.

[airix]

Hi MKChamp.  Thanks for always being so quick with new patches for the mame updates!!

Having a problem with 0.172 patch though.  Compiling on linux_x64 (sdlmame), and getting the following error:

Code: [Select]

/src/osd/sdl/video.cpp: In member function ‘virtual void sdl_osd_interface::update_hi(bool)’:
./src/osd/sdl/video.cpp:299:25: error: ‘sdlinput_poll’ was not declared in this scope  sdlinput_poll(machine());

[MKChamp]

Hi MKChamp.  Thanks for always being so quick with new patches for the mame updates!!

Having a problem with 0.172 patch though.  Compiling on linux_x64 (sdlmame), and getting the following error:

Code: [Select]

/src/osd/sdl/video.cpp: In member function ‘virtual void sdl_osd_interface::update_hi(bool)’:
./src/osd/sdl/video.cpp:299:25: error: ‘sdlinput_poll’ was not declared in this scope  sdlinput_poll(machine());

I don't compile for SDL...just windows...so, I don't find these issues. I uploaded a new hi_172 patch to correct this. Let me know if you find any other issues!

[airix]

Thanks, that was fast!

It fixed that error, but unfortunately produces another one:

Code: [Select]

In file included from /src/emu/ui/dsplmenu.cpp:21:0:
/src/osd/../osd/modules/lib/osdobj_common.h:175:16: error: ‘virtual void osd_common_t::update_hi(bool)’ can be marked override [-Werror=suggest-override virtual void update_hi(bool skip_redraw);

[MomoneDk]

Hello,
I compiled hi172 with windows 7x64, and had the same error with hi171 patch :

Archiving liboptional.a...
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

I will wait the patch from groovymame, but i don't understand why the patch from groovymame works (171 for example), and not the one from arcadecontrols ?

[MKChamp]

Hello,
I compiled hi172 with windows 7x64, and had the same error with hi171 patch :

Archiving liboptional.a...
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

I will wait the patch from groovymame, but i don't understand why the patch from groovymame works (171 for example), and not the one from arcadecontrols ?

171 patch doesn't work for 172. Get the 172 patch.

[MKChamp]

Thanks, that was fast!

It fixed that error, but unfortunately produces another one:

Code: [Select]

In file included from /src/emu/ui/dsplmenu.cpp:21:0:
/src/osd/../osd/modules/lib/osdobj_common.h:175:16: error: ‘virtual void osd_common_t::update_hi(bool)’ can be marked override [-Werror=suggest-override virtual void update_hi(bool skip_redraw);

Go past that and see if it still compiles...that may just be a type of error-warning....

[airix]

Unfortunately it won't go past that:

Code: [Select]

cc1plus: all warnings being treated as errors

[abelenki]

unfortunately, i also can't compile 0.172 with hi_172.txt (i tried both, older and newer re-uploaded patches).

compiling stops with an error:

Code: [Select]

Archiving liboptional.a...
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2
(as in case with MomoneDk).

and yes, i could successfully compile 0.171 with GroovyMAME's hi_0171.diff.

UPDATE: it has nothing to do with hiscore diff - i just tried to compile official sources without any modifications, and i got the same error.

[MomoneDk]

Hello

I tried the patch 172 with the official mame 172 sources.
But it does not work, i don't know why.
It is not a problem of compilation, this patch would not work for nobody

[MKChamp]

Hello

I tried the patch 172 with the official mame 172 sources.
But it does not work, i don't know why.
It is not a problem of compilation, this patch would not work for nobody

Strange. I compiled mine twice with no issues. I'm using Headkaze's compiler. Can you guys check the whole compile log and send any and all warnings/errors?

[MomoneDk]

When i try to compile with the last mame compiler (2.0.169), i can patch successfully, but the compalition does not work (start and stop directly with errors).

I think i am wrong with mame compiler, maybe the directories ? Maybe other thing ?
The last version of mame compiler appear no up to date for use with the last buildtools (over mame 170).
Do you copy/paste the make.exe from the program files to the buildtools/msys64 ?
Do you use older buildtools (until mame 169) ?

[abelenki]

Can you guys check the whole compile log and send any and all warnings/errors?

here are mine:

Code: [Select]

Compiling src/emu/ui/dsplmenu.cpp...
In file included from ../../../../../src/osd/../osd/windows/winmain.h:14:0,
                 from ../../../../../src/emu/ui/dsplmenu.cpp:19:
../../../../../src/osd/modules/lib/osdobj_common.h:175:16: error: 'virtual void osd_common_t::update_hi(bool)' can
 be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
In file included from ../../../../../src/emu/ui/dsplmenu.cpp:19:0:
../../../../../src/osd/../osd/windows/winmain.h:302:16: error: 'virtual void windows_osd_interface::update_hi(bool
)' can be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
cc1plus.exe: all warnings being treated as errors
emu.make:1648: recipe for target '../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o' failed
make[2]: *** [../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o] Error 1
makefile:79: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

[MomoneDk]

Finally, and only with mame compiler, i can compile mame when diff hi172 is applied.
I don't like that, i prefer without mame compiler 

But, for mame compiler when i click on go the first time i have this error after 3 seconds (tried 3 times, always this error) :
make[1]: Leaving directory `D:/buildtools170/msys64/src/3rdparty/genie/build/gmake.windows'

And when i click again on "go", the compilation works  and finish....

[MKChamp]

Can you guys check the whole compile log and send any and all warnings/errors?

here are mine:

Code: [Select]

Compiling src/emu/ui/dsplmenu.cpp...
In file included from ../../../../../src/osd/../osd/windows/winmain.h:14:0,
                 from ../../../../../src/emu/ui/dsplmenu.cpp:19:
../../../../../src/osd/modules/lib/osdobj_common.h:175:16: error: 'virtual void osd_common_t::update_hi(bool)' can
 be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
In file included from ../../../../../src/emu/ui/dsplmenu.cpp:19:0:
../../../../../src/osd/../osd/windows/winmain.h:302:16: error: 'virtual void windows_osd_interface::update_hi(bool
)' can be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
cc1plus.exe: all warnings being treated as errors
emu.make:1648: recipe for target '../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o' failed
make[2]: *** [../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o] Error 1
makefile:79: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Ok...I believe it is now fixed...

[abelenki]

Ok...I believe it is now fixed...

thanks, MKChamp, but i got another similar error with new patch:

Code: [Select]

Compiling src/emu/ui/dsplmenu.cpp...
In file included from ../../../../../src/emu/ui/dsplmenu.cpp:19:0:
../../../../../src/osd/../osd/windows/winmain.h:302:16: error: 'virtual void windows_osd_interface::update_hi(bool
)' can be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
cc1plus.exe: all warnings being treated as errors
emu.make:1648: recipe for target '../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o' failed
make[2]: *** [../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o] Error 1
makefile:79: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

[EMDB]

The original patch worked just fine with the 0172 sources and the latest MC64 2.0.171 without any error or even the need to restart the compilation...

[airix]

Can you guys check the whole compile log and send any and all warnings/errors?

here are mine:

Code: [Select]

Compiling src/emu/ui/dsplmenu.cpp...
In file included from ../../../../../src/osd/../osd/windows/winmain.h:14:0,
                 from ../../../../../src/emu/ui/dsplmenu.cpp:19:
../../../../../src/osd/modules/lib/osdobj_common.h:175:16: error: 'virtual void osd_common_t::update_hi(bool)' can
 be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
In file included from ../../../../../src/emu/ui/dsplmenu.cpp:19:0:
../../../../../src/osd/../osd/windows/winmain.h:302:16: error: 'virtual void windows_osd_interface::update_hi(bool
)' can be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
cc1plus.exe: all warnings being treated as errors
emu.make:1648: recipe for target '../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o' failed
make[2]: *** [../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o] Error 1
makefile:79: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

Ok...I believe it is now fixed...

That patch worked just fine on linux_x64, compiles with no errors and runs fine.
Thanks for the quick changes!

[MKChamp]

Ok...I believe it is now fixed...

thanks, MKChamp, but i got another similar error with new patch:

Code: [Select]

Compiling src/emu/ui/dsplmenu.cpp...
In file included from ../../../../../src/emu/ui/dsplmenu.cpp:19:0:
../../../../../src/osd/../osd/windows/winmain.h:302:16: error: 'virtual void windows_osd_interface::update_hi(bool
)' can be marked override [-Werror=suggest-override]
   virtual void update_hi(bool skip_redraw);
                ^
cc1plus.exe: all warnings being treated as errors
emu.make:1648: recipe for target '../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o' failed
make[2]: *** [../../../../mingw-gcc/obj/x64/Release/src/emu/ui/dsplmenu.o] Error 1
makefile:79: recipe for target 'emu' failed
make[1]: *** [emu] Error 2
makefile:879: recipe for target 'windows_x64' failed
make: *** [windows_x64] Error 2

OK..OK...This one SHOULD WORK I promise! 

[abelenki]

OK..OK...This one SHOULD WORK I promise! 

thank you, MKChamp!! it works perfectly now. much appreciated.

there are two warnings because of two tabs in the last line. i removed them, so it's perfect now.

[MKChamp]

OK..OK...This one SHOULD WORK I promise! 

thank you, MKChamp!! it works perfectly now. much appreciated.

there are two warnings because of two tabs in the last line. i removed them, so it's perfect now. i'm attaching fixed diff to the post.

Great! Uploaded to main page!

[abelenki]

Great! Uploaded to main page!

cool, thanks!

[h0tw1r3]

Now that hiscore support is back in mame (https://github.com/mamedev/mame/tree/master/plugins/hiscore) is there any reason for this patch to include hiscore support?

[MKChamp]

Now that hiscore support is back in mame (https://github.com/mamedev/mame/tree/master/plugins/hiscore) is there any reason for this patch to include hiscore support?

Once it's completely ironed out and has the full support of games as in the current hiscore.dat, then you won't see this patch updated anymore. I can't wait!

[ozfalcon]

Yes it will be great to not have to maintain the Patch 

<UPDATED>
In the meantime I thought I'd let you know current observations of Nag/Loading patches under 0.172 SDL.

Nag patch enabled
1. Disables Nag Screen (As expected)
2. Disables Loading message but leaves white box (Not expected)

Loading patch enabled
1. Disables Loading message and removes white box (As expected - As long as nag patch is not enabled!)
2. When Nag patch is also enabled (typical) it causes the white box to be displayed (See nag patch point 2)

Also noticed in Mame 0.172 is the omission of the Legal Rom Requirement - Not sure if this was on purpose or not.

* Not sure if this has been an issue with previous releases - As I have just jumped up to 0.172 from an earlier release.

[ozfalcon]

Not sure why the Nag screen patch should affect the Loading message. 

[h0tw1r3]

Not sure why the Nag screen patch should affect the Loading message. 

I came up with my own patch for uxme because these patches never actually removed the white border. It appeared to work because when all messages are hidden the white border is never rendered. If any message is displayed before the machine starts, a white border will still be rendered.

Here's my take in patch form: https://playground.btolab.com/sandbox/kb/arcade/emulation/mame/mods/version/0.172/skip-messages-and-remove-white-border.patch.source

Provides three separate options: skip_loading, skip_warning, and render_border.

[ozfalcon]

Interesting, Looking at the loading patch - And it is forced on regardless of the config option setting.

+  //if (!options_get_bool(mame_options(), OPTION_DISABLE_LOADING_PATCH))
+    return;

I came up with my own patch for uxme because these patches never actually removed the white border. It appeared to work because when all messages are hidden the white border is never rendered. If any message is displayed before the machine starts, a white border will still be rendered.

Here's my take in patch form: https://playground.zaplabs.com/sandbox/kb/arcade/emulation/mame/mods/version/0.172/skip-messages-and-remove-white-border.patch.source

Provides three separate options: skip_loading, skip_warning, and render_border.

You have probably done what I was just about to do. Thanks for the link I'll have a look and read.
Given that the Hi_Score patch will more than likely move to the LUA script, It's probably time to look at liberating the other patches.

Of Course I really have no say in what happens - That's upto MKChamp - But I'm sure he's keen as previously indicated.

[ozfalcon]

I came up with my own patch for uxme because these patches never actually removed the white border. It appeared to work because when all messages are hidden the white border is never rendered. If any message is displayed before the machine starts, a white border will still be rendered.

Here's my take in patch form: https://playground.zaplabs.com/sandbox/kb/arcade/emulation/mame/mods/version/0.172/skip-messages-and-remove-white-border.patch.source

Provides three separate options: skip_loading, skip_warning, and render_border.

Just looking at your Skip_Loading sections compared to Hi_Score Disable_Loading_Patch

It seems there are three areas of interest:
fgrep "ui().set_startup_text"  * -R

Code: [Select]

emu/machine.cpp: ui().set_startup_text("Initializing...", true);
emu/romload.cpp: machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp: machine.ui().set_startup_text(loadingMessage,FALSE);

Your patch does:
emu/machine.cpp:   ui().set_startup_text("Initializing...", true);
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);

Hi_Score does:
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp:         machine.ui().set_startup_text(loadingMessage,FALSE);

Any reason your patch does not alter cps2crpt.cpp?

Will look at the rest of the patch (skip_warning, and render_border) over the week.

[h0tw1r3]

Just looking at your Skip_Loading sections compared to Hi_Score Disable_Loading_Patch

It seems there are three areas of interest:
fgrep "ui().set_startup_text"  * -R

Code: [Select]

emu/machine.cpp: ui().set_startup_text("Initializing...", true);
emu/romload.cpp: machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp: machine.ui().set_startup_text(loadingMessage,FALSE);

Your patch does:
emu/machine.cpp:   ui().set_startup_text("Initializing...", true);
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);

Hi_Score does:
emu/romload.cpp:      machine().ui().set_startup_text(buffer, false);
mame/machine/cps2crpt.cpp:         machine.ui().set_startup_text(loadingMessage,FALSE);

Any reason your patch does not alter cps2crpt.cpp?

Will look at the rest of the patch (skip_warning, and render_border) over the week.

Thanks for reviewing the patch. Uploaded a new version. Removed some irrelevant code, fixed the cps2 decrypt message showing and simplified.

[ozfalcon]

For a different method of message suppression and writeup on using the MinGW environment.
http://forum.attractmode.org/index.php?topic=348.0

[ozfalcon]

Just looked at the latest revision of @h0tw1r3 patch

This patch pretty much gets to the root of each area.
Looks like a much cleaner way of doing things.
& it's small - So it should be easy to manage..

Still have to test it out.