hiscore diff (with no nag/white box removal)

[pottzman]

I put the 153 patch link over to http://forum.arcadecontrols.com/index.php?action=dlattach;topic=135823.0;attach=307416

Whoever updated the patch to work in 153, thanks...I was out of town and it saved me time!

Hi MKChamp,

I've always appreciated your work with the hiscore support but this latest version 153 has a problem. It does not save any changes to the mame.ini file. If I use the standard mameui64 the default mame options save fine but if I compile mameui64 and include your hiscore patch I can change the default mame options but they do not seem to save the changes to the mame.ini file. This is the first version of your patch that I have had any problem with. Just wondering if it is just me that is having this problem or not.

thanks in advance

pottzman

[DoTheDonkeyKonga]

Hi guys,

Did anyone manage to save the hiscore_149 patch by any chance?

I don't think I've got the time or the will to update my romset to the latest build and I was hoping on compiling a hiscore/nonag version of mame with load state messages also removed - which is also why I can't just opt for a pre-compiled hiscore 149 as I need to edit the source myself before compiling.

Please somebody tell me I'm in luck!

[ozfalcon]

Just wondering if the "disable_loading_patch" is known to cause video settings being lost.

While helping Lord-Data, He uncovered this problem. And I found this reference & workaround:
http://www.mameworld.info/ubbthreads/showflat.php?&Number=297976

Looking at the patch, There doesn't seem to be much to this section. I'll look into it & see if I can find something.

Ok, Just to follow up on this post. This is regarding SDLMAME. it does not affect Windows builds of Mame.

Turns out, The "disable_loading_patch" does not work under SDLMame - Because there is no code for it.

After creating my own version, I happened across this post. I wish I had found the post 1st....
Thanks MKChamp, Glad to see I was on the right track! Even though I just reinvented the wheel....
https://forum.arcadecontrols.com/index.php/topic,64298.msg1110111.html#msg1110111

Also to note is Bitbytebit post and patch.
https://forum.arcadecontrols.com/index.php/topic,64298.msg1115992.html#msg1115992

However this is not the end of the tale.
There is a bug attached to the missing SDL code base and to Bitbytebit's patch.

Bug:
When

Code: [Select]

&window->get_primitives(window) is not executed then game.ini is reset to default.

Occurrence:
1. When Disable Loading Screen is enabled on SDLMame (There is no SDL Code branch for this option)
2. If Bitbytebit's patch is used, The code containing the above line is commented out - resulting in the bug.

Reproduce:
1. load game eg. gyruss
2. go to video options and set to cocktail and exit game.
3. load game and exit game again.
4. load game once more and observe the video mode has reset.

Followup to this next post

[ozfalcon]

I have added the SDL code for the disable_loading_patch and it now operates correctly without any bugs.
It is integrated in the same fashion as the windows update_hi code.
No other changes have been made to the way Hi Score patch operates.
Note: New sections are labeled OzFalcon for easy identification, They are just copies of MKChamps code
modified for SDL by me and no credit is meant to be assumed by the labeling.

Changes:
/src/osd/sdl/video.c  --> Added update_hi
/src/osd/sdl/window.c  --> Added sdlwindow_video_window_update_hi
/src/osd/sdl/window.h  --> Declare sdlwindow_video_window_update_hi
/src/osd/sdl/osdsdl.h  --> Declare update_hi

New Hi Score Patch is attached as zip.
Just to clarify, The SDL code has been included in this patch.
It is a complete Hi Score patch for both Windows and SDL Mame.

This patch was built with Calamity's 0.153 updated hi score patch ( 'global_free' ---> 'global_free_array').
http://forum.arcadecontrols.com/index.php/topic,135823.msg1432446.html#msg1432446

[ozfalcon]

Similar bugs.....
https://forum.arcadecontrols.com/index.php/topic,64298.msg1193645.html#msg1193645
https://forum.arcadecontrols.com/index.php/topic,64298.msg1311733.html#msg1311733

[Calamity]

Did anyone manage to save the hiscore_149 patch by any chance?

I'm posting the ones that I still keep in my hd, in case they can be of help.

[Calamity]

Just to clarify, The SDL code has been included in this patch.

Hi ozfalcon, thanks a lot for the fix. It would be great news for me if MKChamp adopted the SDL bits in his patch so I can remove those from the GroovyMAME patch.

[DoTheDonkeyKonga]

I'm posting the ones that I still keep in my hd, in case they can be of help.

Calamity you are a living legend! Thank you 

[ozfalcon]

Here are some more older patches:

[ozfalcon]

Just to clarify, The SDL code has been included in this patch.

Hi ozfalcon, thanks a lot for the fix. It would be great news for me if MKChamp adopted the SDL bits in his patch so I can remove those from the GroovyMAME patch.

Yes, It would be good for me also if this sdl code was included in the base Hi Score patch. Makes building upon it easier.

[pottzman]

so just to clarify is anybody having the same issue as me with mame 153 hiscore patch?

[ozfalcon]

so just to clarify is anybody having the same issue as me with mame 153 hiscore patch?

 If I use the standard mameui64 the default mame options save fine but if I compile mameui64 and include your hiscore patch I can change the default mame options but they do not seem to save the changes to the mame.ini file.

Standard Mame doesn't change the mame.ini file and the Hi Score patch doesn't effect this in any way.
This appears to be a function of MameUI - Which as you say - Is broken when you apply the Hi Score patch.
You need to follow up on the MameUI forums as to what code in MameUI needs to change for it to work.

[trickyd]

This issue is known as 153 is quite buggy and a new 153.1 uisorce has been released. If your having problems still just edit .ini in the ini folder and that will save the changes.

[abelenki]

sorry about files couldn't be downloaded.

now i paid for domain, and files should be back on-line in one day or so.

[abelenki]

That domain actually belong to abelenki. I would ftp the files there. The only two files I have on my local pc is the latest (153) and the one previous to that. Unless abelenki can get that domain back up or anyone else had a copy of ALL the other files...looks like they will be gone with the wind.

sorry for the inconvenience once again. i had serious life problems, and couldn't update the domain.

MKChamp, now everything is back, so you can use FTP as you did.

p.s.: for someone, it can take more time when DNS is updated.

[Tzakiel]

I'm able to report that with the latest hiscore.dat, saving hiscores now works for the newer CAVE SH-3 games like ESPgaluda II, dai fukkatsu, etc.

[MKChamp]

MKChamp, now everything is back, so you can use FTP as you did.

Thanks abelenki! And the world turns....

[trickyd]

Tried to compile mame from the ume153ex2 source had multiple errors

[cugel]

Hello all,

I'm still with a problem with recent version, highscore doesn’t works

Ubuntu 14.04
mame 0.153 + patch
hiscore.dat in mame directory (config directory) + directory hi

Maybe I missed something ?

No problem with nomag

[cugel]

The problem is here

+    state.mem_range = NULL;
+    emu_file f(OPEN_FLAG_READ);
+      filerr = f.open("hiscore", ".dat");

If I try mame with command line, like this
mame /roms/1943.zip -> No problem with Highscore

But behind a fronted the file hiscore.dat seem never open ...

So, I changed this line by

f.open("/games/roms/hiscore", ".dat");

And it works !
Perhaps the best way to definitely fix this problem (at least with Linux) should be to add an option in mame.ini ? Something like hiscoredatpath 

Fred

[bigrap75]

Hello everyone, this is my first time in this forum and I was wondering is there a way I can save my hi scores in the mame32 103u2 version or do I have to upgrade to the latest version of Mame? Thanks!!!

[Benzinbruder]

@bigrap75: There's no support for highscores for mame v.103, so you should probably upgrade.

I tried compiling the source today, unluckily I was very unlucky doing it.
Any ideas what could have gone wrong? I followed Mr. Do's instructions quite carefully. 

EDIT:
Found the solution myself the second after posting this...
I had only copied the contents of the mingw64-w64 folder into my MinGW directory. Thought I'd only need the 64-bit part.
Now there's both mingw64-w64 and mingw64-w32 in the MinGW directory. Compiling...

[Jumpstile]

Anything for .154 yet? Thanks in advance!

 - J*

[Ansa89]

Probably I will look into it this weekend.

[MKChamp]

Anything for .154 yet? Thanks in advance!

It's been so long since they released anything, I quit checking. At any rate, the patch has been updated for 154...download away...

[ozfalcon]

UPDATED (Fixed compile error)

The "disable_loading_patch" does not work under SDLMame - Because there is no code for it.
I have added the SDL code for the disable_loading_patch and it now operates correctly for SDL.
No other changes have been made to the way Hi Score patch operates.

Note: New sections are labeled OzFalcon for easy identification, They are duplicates of MKChamps code
modified for SDL by me and no credit is meant to be assumed by the labeling.

Changes:
/src/osd/sdl/video.c  --> Added update_hi
/src/osd/sdl/window.c  --> Added sdlwindow_video_window_update_hi
/src/osd/sdl/window.h  --> Declare sdlwindow_video_window_update_hi
/src/osd/sdl/osdsdl.h  --> Declare update_hi

Just to clarify, The SDL code has been included in this patch.
It is a complete Hi Score patch for both Windows and SDL Mame.

[MKChamp]

Thanks ozfalon. I made that the baseline patch (re-uploaded hi_154.txt) and will use it going forward.

Gracias!
Jason

[Calamity]

Thanks for including the patches SDL!

The current patch however crashes the patch command here, due to mixed DOS/Unix line endings. Here's a fixed one.

[MKChamp]

Thanks for including the patches SDL!

The current patch however crashes the patch command here, due to mixed DOS/Unix line endings. Here's a fixed one.

Thanks for correcting this. I re-uploaded the 154 patch to this one. Hope all is well!

[ozfalcon]

Thats odd, Now when I patch I get this error
patch --binary -p0 -E <../1.HiScorePatch0154/hi_154.fixed.txt
patching file src/emu/emu.mak
patch: **** malformed patch at line 5:

However the original SDL patch works ok
patch --binary -p0 -E <../1.HiScorePatch0154/hi_154.orig.txt
patching file src/emu/emu.mak
patching file src/emu/emuopts.c
patching file src/emu/emuopts.h
patching file src/emu/hiscore.c
patching file src/emu/hiscore.h
patching file src/emu/machine.c
patching file src/emu/machine.h
patching file src/emu/mame.c
patching file src/emu/profiler.c
patching file src/emu/profiler.h
patching file src/emu/romload.c
patching file src/emu/ui/ui.c
patching file src/emu/video.c
patching file src/emu/video.h
patching file src/mame/machine/cps2crpt.c
patching file src/osd/osdepend.c
patching file src/osd/osdepend.h
patching file src/osd/sdl/osdsdl.h
patching file src/osd/sdl/video.c
patching file src/osd/sdl/window.c
patching file src/osd/sdl/window.h
patching file src/osd/windows/video.c
patching file src/osd/windows/window.c
patching file src/osd/windows/window.h
patching file src/osd/windows/winmain.h


Incase patch version has something to do with it:
patch --version
GNU patch 2.7.1
Copyright (C) 2003, 2009-2012 Free Software Foundation, Inc.
Copyright (C) 1988 Larry Wall

License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Larry Wall and Paul Eggert

[ozfalcon]

Thanks for including the patches SDL!

The current patch however crashes the patch command here, due to mixed DOS/Unix line endings. Here's a fixed one.

Calamity, What system and how are you applying the patches?
I'm guessing windows, But there shouldn't be any difference from previous patches.

Do you get the same result from applying the 154 Pre SDL patch?
(Attached)

[Calamity]

It's the patch build that comes with the official MAME toolchain:

Code: [Select]

patch 2.5.4
Copyright 1984-1988 Larry Wall
Copyright 1989-1999 Free Software Foundation, Inc.

This program comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of this program
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

written by Larry Wall and Paul Eggert
The pre-SDL patch works fine here.

The only change I did to your patch is saving it again with Sublime Text 2, making sure the line endings option was marked as "Windows". After that it worked fine with this version of 'patch'.

[ozfalcon]

It's the patch build that comes with the official MAME toolchain:

Code: [Select]

patch 2.5.4
Copyright 1984-1988 Larry Wall
Copyright 1989-1999 Free Software Foundation, Inc.

This program comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of this program
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

written by Larry Wall and Paul Eggert
The pre-SDL patch works fine here.

The only change I did to your patch is saving it again with Sublime Text 2, making sure the line endings option was marked as "Windows". After that it worked fine with this version of 'patch'.

ok, I wonder if it's the way the patch is created or if the new sdl parts have unix linefeeds.

Does it give you a line number it fails on?

[Calamity]

Code: [Select]

D:\test>patch -p0 -E <HiScore_0154_sdl.diff
patching file src/emu/emu.mak
Assertion failed: hunk, file patch-2.5.4/patch.c, line 343

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

D:\test>


[ozfalcon]

Code: [Select]

D:\test>patch -p0 -E <HiScore_0154_sdl.diff
patching file src/emu/emu.mak
Assertion failed: hunk, file patch-2.5.4/patch.c, line 343

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

D:\test>


Will fire up the laptop (windows) and see if I can make the patch work for both Windows & Linux.
Seems using the Linux tools causes an issue for applying the patch under Windows.

[Calamity]

Will fire up the laptop (windows) and see if I can make the patch work for both Windows & Linux.
Seems using the Linux tools causes an issue for applying the patch under Windows.

This issue is an old one. If you search the GM subforum you'll see several cases where patches resulting from collaboration of Windows & Linux users have caused problems, because of the different line endings etc. To be safe I always create and apply the patches using then Windows tools (the ones from the MAME toolchain), even when working with Linux (ironically).

Also, using Linux text editors for the MAME source code has caused me problems in the past with mixed line endings. I believe that git takes care of all these annoyances with different line endings.

[ozfalcon]

Will fire up the laptop (windows) and see if I can make the patch work for both Windows & Linux.
Seems using the Linux tools causes an issue for applying the patch under Windows.

This issue is an old one. If you search the GM subforum you'll see several cases where patches resulting from collaboration of Windows & Linux users have caused problems, because of the different line endings etc. To be safe I always create and apply the patches using then Windows tools (the ones from the MAME toolchain), even when working with Linux (ironically).

Also, using Linux text editors for the MAME source code has caused me problems in the past with mixed line endings. I believe that git takes care of all these annoyances with different line endings.

I'll need to search the GM subforum as you mentioned to catch up on what was discussed.
Interestingly your use of Sublime Text 2 causes patches to fail under Linux (Possibly Mac too?).
Yes, It looks like the safe way is to create the patches with the windows Mame toolchain utils.

Hopefully, Now that the SDL code is in MKCHAMPS build tree - When he creates the patch it will work for both Linux & Windows.

[ozfalcon]

In the mean time, I have re-created the patch under the windows mame toolchain.
It now works (tested) under both Windows and Linux.

Hopefully this will be the final 
Just to note: Applying patches under Linux seems to be ok, It's just the creation of patches with diff under Linux that caused issue.

[MKChamp]

Thanks guys for getting it sorted out. I've uploaded the latest patch and will use that going forward!

[Skeeball_Fanatic]

Thanks guys for getting it sorted out. I've uploaded the latest patch and will use that going forward!

Alright.  Total newbie here, so be prepared.  I'm using .154.

I've followed the instructions on the first page of this post to the letter (as far as I'm aware).  I used Mr Do's instructions to compile MAME (I'm such a newb that I don't even know what compiling means, I just followed the instructions) and I downloaded the correct diff file and again followed the instructions to the letter (as far as I'm aware - I think you're getting some idea of my competency level here).

The Mame executable runs just fine, but I'm still getting the nagscreen/loading screen and I'm not sure what to do from here.  Bearing in mind I'm not going to understand a heap of technical terminology, does anyone know what I can do from here?  Have I even given you enough info to know what my problem is?

I'm using Windows 7, 64 Bit if that matters.

Thanks in advance and apologies for my idiocy.