Main > Software Forum
hiscore diff (with no nag/white box removal)
<< < (241/250) > >>
dav777:
Hi, can anyone put me on the right track to use the suppression patches? I am pulling my hair our trying to patch the source code. I keep getting the following:


--- Code: ---c:\buildtools\src\0182>patch -l -p0 -E <..\suppression_0182u0.diff
patching file src/emu/render.cpp
Hunk #1 FAILED at 1398 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file src/emu/render.cpp.rej
patching file src/frontend/mame/ui/ui.cpp
Hunk #1 FAILED at 317 (different line endings).
Hunk #2 FAILED at 779 (different line endings).
2 out of 2 hunks FAILED -- saving rejects to file src/frontend/mame/ui/ui.cpp.rej

--- End code ---
ozfalcon:

--- Quote from: dav777 on February 05, 2017, 12:13:38 pm ---Hi, can anyone put me on the right track to use the suppression patches? I am pulling my hair our trying to patch the source code. I keep getting the following:


--- Code: ---c:\buildtools\src\0182>patch -l -p0 -E <..\suppression_0182u0.diff
patching file src/emu/render.cpp
Hunk #1 FAILED at 1398 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file src/emu/render.cpp.rej
patching file src/frontend/mame/ui/ui.cpp
Hunk #1 FAILED at 317 (different line endings).
Hunk #2 FAILED at 779 (different line endings).
2 out of 2 hunks FAILED -- saving rejects to file src/frontend/mame/ui/ui.cpp.rej

--- End code ---

--- End quote ---

Use the binary option

--- Code: ---patch --binary -p0 -E <patch.diff

--- End code ---
BGoulette:
[deleted]

Took the Attract Mode forums' approach. Seems to be working!
abelenki:
suppression_0182u0.txt works fine with 0.183 source tree.
headkaze:

--- Quote from: fleskebacon on November 05, 2016, 05:17:57 pm ---I'm having a strange problem when compiling 0.179 for Windows x64. Everything works perfectly, but when I use the compiled file, exiting Mame gives me rubbish text output. I've tried compiling with numerous options, but it happens even when compiling without changing anything at all - installing fresh compile tools and untouched source files doesn't solve it. Never experienced this before, I think.

And this doesn't happen when using the pre-compiled version, so it boils down to being something that happens when I compile.

Anyone know what this is, and how to fix it? It's not a huge problem, as everything else seems to be working perfectly, but something obviously isn't right.

--- End quote ---

I tracked down the bug in MAME and reported it to MAMEDev so it should hopefully be fixed in the next release.

If you want to fix it yourself for now; the problem is specifically in the guid_to_string() method located in the file src\osd\modules\input\input_dinput.h

Open input_dinput.h in a text editor and do a search for "sprintf_s" replacing it with "snprintf". Now compile it again and the bug is fixed.

EDIT: It appears compiling MAME with the latest compile tools (GCC 6.3.0) doesn't require this patch.
Navigation
Message Index
Next page
Previous page

Go to full version