Main > Software Forum

MAME scripty things!

<< < (4/6) > >>

PL1:
Noticed your latest pull request on Aaron's Github.

You may also want to make these changes to Readme.md.

Change 1:

--- Quote ---Can you launch Defender in MAME? "mame.exe defender" - If not, you need to find the correct version of the "defender.zip" ROM file for your version of MAME and put it the "\mame\roms" folder. (ROM not provided here.)

--- End quote ---
to

--- Quote ---Can you launch Defender and Stargate in MAME? "mame.exe defender" and "mame.exe stargate" - If not, you need to find the correct version of the "defender.zip" and "stargate.zip" ROM files for your version of MAME and put them the "\mame\roms" folder. (ROMs not provided here.)

--- End quote ---

Change 2:

--- Quote ---Make a text file named "defender.ini" in either the ini folder or the same folder as the MAME executable. - It should contain the text "plugin defenderlr".

--- End quote ---
to

--- Quote ---Make text files named "defender.ini" and "stargate.ini" in either the ini folder or the same folder as the MAME executable. - They should contain the text "plugin defenderlr".

--- End quote ---

Change 3:

--- Quote ---Now you're ready to play Defender and blast those pesky aliens.

--- End quote ---
to

--- Quote ---Now you're ready to play Defender or Stargate and blast those pesky aliens.

--- End quote ---


--- Quote from: 10yard on November 29, 2021, 09:02:07 am ---I have merged the stargate change into defenderlr and tested ok.   Plugin version is now 4.0.  I have sent a request to Aaron to update his original git repo.

I made a fork so you can easily grab the files for the v4 release in a zip at: https://github.com/10yard/defenderlr/releases

--- End quote ---
I'll try them now.   ;D


Scott
EDIT: Merged version works great.   ;D

PL1:
Cleaned up the Readme.md file using Wordpad.
- Made the changes mentioned above.
- Added link to Oomek's original plugin thread to "the original by oomek here ".
- Reworded a few lines for better flow.
- Added step numbers to the Configuring MAME section so it's easier to keep track of where you are in the process.
- Put all commands and settings in single quotes (') so they show up in a grey box on Github.
- Put all folders and filenames and folders in double quotes. (")
- Added spaces in the .ini file quote sections so they look more like actual .ini files.
-- The right column entries line up in Wordpad, but not in Notepad.   :banghead:
-- The alignment may need to be tweaked using Github's file editor.   :dunno


Scott

10yard:
Thank you muchly Scott  :cheers:

Outside of github I tend to use https://stackedit.io/ for editing/reviewing markdown.
I made a tweak to your latest readme to emphasise code blocks using ``` tags.  Can you review it using above link?  You will need to click on "Start Writing" and then paste the text into the left pane.  If that's all good with you then I will send Aaron another pull request.
 
Jon

PL1:

--- Quote from: 10yard on December 03, 2021, 04:50:34 am ---Outside of github I tend to use https://stackedit.io/ for editing/reviewing markdown.

--- End quote ---
That one doesn't play well with my browser, but this one does.   ;D
https://markdown-editor.github.io/


--- Quote from: 10yard on December 03, 2021, 04:50:34 am ---I made a tweak to your latest readme to emphasise code blocks using ``` tags.

--- End quote ---
Just figured out what I was doing wrong.   :lol

I used the single-quote ' (un-shifted " key) next to the ENTER key instead of the backtick ` (un-shifted ~ key) next to the ESC key.   :embarassed:

I understand why you would use a ``` (fenced code block) tag for multi-line .ini file content, but why use it instead of a ` (code) tag for the inline commands and settings?
- You used single backtick code tags lots of times for inline code in your DKAFE Readme.md file.


--- Quote from: 10yard on December 03, 2021, 04:50:34 am ---If that's all good with you then I will send Aaron another pull request.

--- End quote ---
Line 18: Add double quotes around mame.ini. (all other filenames have them)
  Change

--- Quote ---2. If you don't already have one, create a mame.ini file using the ```mame -cc``` (create config) command.
--- End quote ---
  to

--- Quote ---2. If you don't already have one, create a "mame.ini" file using the ```mame -cc``` (create config) command.
--- End quote ---
----------------------
Add a blank line between lines 15 and 16 so current line 16 renders as a paragraph like current line 20 does.
----------------------
Line 15:
- Change the single-quotes to backticks -- your choice single (code tag, shown) or triple. (fenced code block tag)
- Delete the second question mark (you're stating the correct commands to launch the games) or put the second half of the line in one set of parentheses or put the command after the game name.
  Change

--- Quote ---1. Can you launch Defender and Stargate in MAME? 'mame.exe defender' and 'mame.exe stargate'?
--- End quote ---
  to

--- Quote ---1. Can you launch Defender and Stargate in MAME? `mame.exe defender` and `mame.exe stargate`
--- End quote ---
  or

--- Quote ---1. Can you launch Defender and Stargate in MAME? (`mame.exe defender` and `mame.exe stargate`)
--- End quote ---
  or

--- Quote ---1. Can you launch Defender (`mame.exe defender`) and Stargate  (`mame.exe stargate`) in MAME?
--- End quote ---

The only remaining odd rendering is on lines 20, 35, 60, and 66 where the multiple spaces like "defenderlr    0" are auto-formatted to a single space like "defenderlr 0" -- not sure if it's possible to change this.   :dunno


Scott

10yard:

--- Quote from: PL1 ---Just figured out what I was doing wrong.   :lol

I used the single-quote ' (un-shifted " key) next to the ENTER key instead of the backtick ` (un-shifted ~ key) next to the ESC key.   :embarassed:

I understand why you would use a ``` (fenced code block) tag for multi-line .ini file content, but why use it instead of a ` (code) tag for the inline commands and settings?
- You used single backtick code tags lots of times for inline code in your DKAFE Readme.md file.

--- End quote ---

Yes,  it's the back tick for quotes.  That was just a brain fart from me.  I'd forgotten that you can use a single one for inline comments. :lol   


--- Quote from: PL1 ---Line 18: Add double quotes around mame.ini. (all other filenames have them)
  Change

--- Quote ---2. If you don't already have one, create a mame.ini file using the ```mame -cc``` (create config) command.
--- End quote ---
  to

--- Quote ---2. If you don't already have one, create a "mame.ini" file using the ```mame -cc``` (create config) command.
--- End quote ---
----------------------
Add a blank line between lines 15 and 16 so current line 16 renders as a paragraph like current line 20 does.
----------------------
Line 15:
- Change the single-quotes to backticks -- your choice single (code tag, shown) or triple. (fenced code block tag)
- Delete the second question mark (you're stating the correct commands to launch the games) or put the second half of the line in one set of parentheses or put the command after the game name.
  Change

--- Quote ---1. Can you launch Defender and Stargate in MAME? 'mame.exe defender' and 'mame.exe stargate'?
--- End quote ---
  to

--- Quote ---1. Can you launch Defender and Stargate in MAME? `mame.exe defender` and `mame.exe stargate`
--- End quote ---
  or

--- Quote ---1. Can you launch Defender and Stargate in MAME? (`mame.exe defender` and `mame.exe stargate`)
--- End quote ---
  or

--- Quote ---1. Can you launch Defender (`mame.exe defender`) and Stargate  (`mame.exe stargate`) in MAME?
--- End quote ---

The only remaining odd rendering is on lines 20, 35, 60, and 66 where the multiple spaces like "defenderlr    0" are auto-formatted to a single space like "defenderlr 0" -- not sure if it's possible to change this.   :dunno

--- End quote ---

Unfortunately, multiple/tab spaces for inline code are not supported.  Otherwise,  all was updated. 

Thanks for being so thorough! 

I've sent another pull request to Aaron.


Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version